From: Kito Cheng <kito.cheng@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Kito Cheng <kito.cheng@sifive.com>,
gcc-patches@gcc.gnu.org, jim.wilson.gcc@gmail.com,
palmer@dabbelt.com, andrew@sifive.com,
christoph.muellner@vrull.eu
Subject: Re: [PATCH] RISC-V: Add h extension support
Date: Wed, 26 Oct 2022 16:34:34 +0800 [thread overview]
Message-ID: <CA+yXCZCczZLMpvJh=zycyBDxLpC4ZoC0jUbwugtcJwsWPY=ipg@mail.gmail.com> (raw)
In-Reply-To: <2be969b2-8188-2141-d8ed-b54d9af7c947@gmail.com>
Thanks for the review, committed :)
On Mon, Oct 24, 2022 at 11:05 PM Jeff Law via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> On 10/24/22 03:55, Kito Cheng wrote:
> > `h` was the prefix of multi-letter extension name, but it become a
> > extension in later RISC-V isa spec.
> >
> > Fortunately we don't have any extension really defined is prefixed
> > with `h`, so we can just change that.
> >
> > gcc/ChangeLog:
> >
> > * common/config/riscv/riscv-common.cc (riscv_ext_version_table):
> > Add `h`.
> > (riscv_supported_std_ext): Ditto.
> > (multi_letter_subset_rank): Remove `h`.
> > (riscv_subset_list::parse_std_ext): Handle `h` as single letter
> > extension.
> > (riscv_subset_list::parse): Ditto.
> >
> > gcc/testsuite/ChangeLog:
> >
> > * testsuite/gcc.target/riscv/arch-18.c: New.
> > * testsuite/gcc.target/riscv/arch-5.c: Remove test for prefixed
> > with `h`.
> > * testsuite/gcc.target/riscv/predef-23.c: New.
>
> OK.
>
>
> Jeff
>
>
prev parent reply other threads:[~2022-10-26 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 9:55 Kito Cheng
2022-10-24 15:04 ` Jeff Law
2022-10-26 8:34 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZCczZLMpvJh=zycyBDxLpC4ZoC0jUbwugtcJwsWPY=ipg@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).