From: Lewis Hyatt <lhyatt@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libcpp: Improve location for macro names [PR66290]
Date: Tue, 20 Feb 2024 09:32:27 -0500 [thread overview]
Message-ID: <CAA_5UQ4juJNdq6H-9OsGsQR8xGT6dLfORKc8zMV1eH0Ena-D7g@mail.gmail.com> (raw)
In-Reply-To: <orttm3oiqb.fsf@lxoliva.fsfla.org>
On Mon, Feb 19, 2024 at 11:36 PM Alexandre Oliva <oliva@adacore.com> wrote:
>
> This backport for gcc-13 is the first of two required for the
> g++.dg/pch/line-map-3.C test to stop hitting a variant of the known
> problem mentioned in that testcase: on riscv64-elf and riscv32-elf,
> after restoring the PCH, the location of the macros is mentioned as if
> they were on line 3 rather than 2, so even the existing xfails fail. I
> think this might be too much to backport, and I'm ready to use an xfail
> instead, but since this would bring more predictability, I thought I'd
> ask whether you'd find this backport acceptable.
>
> Regstrapped on x86_64-linux-gnu, along with other backports, and tested
> manually on riscv64-elf. Ok to install?
Sorry that test is causing a problem, I hadn't realized at first that
the wrong output was target-dependent. I feel like simply deleting
this test g++.dg/pch/line-map-3.C from GCC 13 branch should be fine
too, as a safer alternative, if release managers prefer? It doesn't
really need to be on the branch, it's only purpose is to remind me to
fix the underlying issue for GCC 15...
-Lewis
next prev parent reply other threads:[~2024-02-20 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 4:35 Alexandre Oliva
2024-02-20 14:32 ` Lewis Hyatt [this message]
2024-02-22 8:56 ` Richard Biener
2024-02-22 14:46 ` Lewis Hyatt
-- strict thread matches above, loose matches on Subject: below --
2022-08-05 16:04 Lewis Hyatt
2023-06-20 15:40 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA_5UQ4juJNdq6H-9OsGsQR8xGT6dLfORKc8zMV1eH0Ena-D7g@mail.gmail.com \
--to=lhyatt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).