From: Lewis Hyatt <lhyatt@gmail.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: Ping^2: 2 libcpp patches
Date: Tue, 23 Aug 2022 19:47:20 -0400 [thread overview]
Message-ID: <CAA_5UQ5O1hqkNuO-ESW1Fzg1AL8kndMVSnev1ezZTGvNbbynSg@mail.gmail.com> (raw)
In-Reply-To: <CAA_5UQ4Hqsy6Z2gBPM9oOuaUBkSncLmCuV4GDNPmGpquVYa+zQ@mail.gmail.com>
On Tue, Aug 16, 2022 at 9:50 AM Lewis Hyatt <lhyatt@gmail.com> wrote:
>
> On Wed, Jul 20, 2022 at 8:56 PM Lewis Hyatt <lhyatt@gmail.com> wrote:
> >
> > Hello-
> >
> > May I please ping these two preprocessor patches?
> >
> > For PR103902:
> > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596704.html
> >
> > For PR55971:
> > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596820.html
> >
> > Thanks!
>
> Hello-
>
> I would very much appreciate feedback on these two patches please?
>
> For the first patch, I think it is a worthwhile goal to fix all the
> places where libcpp fails to support UTF-8 correctly, and this is one
> of two remaining ones that I'm aware of. I can fix the other case
> (handling of #pragma push_macro) once this one is in place.
>
> The second patch is about libcpp not allowing raw strings containing
> newlines in preprocessor directives, which is a nearly decade-old
> glitch that I think is also worth addressing.
>
> Thanks!
>
> -Lewis
Hello-
I CCed Joseph on this ping last week, but he suggested asking other
maintainers to take a look, so I hope it's OK I am doing that now?
Jakub, I thought it could make sense to ask you please, since I saw
you working on lex.cc recently as well, and also since you commented
on PR55971 nine years ago :). With an uptick in development of libcpp
to support new C++23 features, I think the chances that my patches
will eventually conflict with those are increasing, so it would be
great to get them reviewed. As of current master branch, they still
apply and regtest fine. Thanks very much.
-Lewis
prev parent reply other threads:[~2022-08-23 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 13:50 Lewis Hyatt
2022-08-16 16:57 ` Joseph Myers
2022-08-23 23:47 ` Lewis Hyatt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA_5UQ5O1hqkNuO-ESW1Fzg1AL8kndMVSnev1ezZTGvNbbynSg@mail.gmail.com \
--to=lhyatt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).