From: Lewis Hyatt <lhyatt@gmail.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551] (was: Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases)
Date: Tue, 12 Jul 2022 07:50:56 -0400 [thread overview]
Message-ID: <CAA_5UQ6i6v+OxyiiVLS3my8x5LsJW3nYkEsgZ1zgqow-2CuLYA@mail.gmail.com> (raw)
In-Reply-To: <87bktu4z7m.fsf@euler.schwinge.homeip.net>
On Tue, Jul 12, 2022 at 2:33 AM Thomas Schwinge <thomas@codesourcery.com> wrote:
>
> Hi!
>
> On 2022-07-11T11:27:12+0200, I wrote:
> > [...], I've just pushed to master branch
> > commit 06b2a2abe26554c6f9365676683d67368cbba206
> > "Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases"
>
> > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c
> > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c
> > @@ -17,7 +17,7 @@ const int n = 100;
> > #define check_reduction(gwv_par, gwv_loop) \
> > { \
> > s1 = 2; s2 = 5; \
> > -DO_PRAGMA (acc parallel gwv_par copy (s1, s2)) \
> > +DO_PRAGMA (acc parallel gwv_par copy (s1, s2)) /* { dg-line DO_PRAGMA_loc } */ \
> > DO_PRAGMA (acc loop gwv_loop reduction (+:s1, s2)) \
> > for (i = 0; i < n; i++) \
> > { \
> > @@ -45,8 +45,10 @@ main (void)
> >
> > /* Nvptx targets require a vector_length or 32 in to allow spinlocks with
> > gangs. */
> > - check_reduction (num_workers (nw) vector_length (vl), worker);
> > - /* { dg-warning "region is vector partitioned but does not contain vector partitioned code" "test1" { target *-*-* } pragma_loc } */
> > + check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg-line check_reduction_loc }
> > + /* { dg-warning "22:region is vector partitioned but does not contain vector partitioned code" "" { target *-*-* } pragma_loc }
> > + { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* } DO_PRAGMA_loc }
> > + { dg-note "3:in expansion of macro 'check_reduction'" "" { target *-*-* } check_reduction_loc } */
>
> Oh my, PR101551 "[offloading] Differences in diagnostics etc."
> strikes again... The latter two 'note' diagnostics are currently
> only emitted in non-offloading configurations. I've now pushed to
> master branch commit 3723aedaad20a129741c2f6f3c22b3dd1220a3fc
> "XFAIL 'offloading_enabled' diagnostics issue in
> 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551]", see attached.
>
Would you mind please confirming how I need to run configure in order
to get this configuration? Then I can look into why the difference in
location information there. Thanks....
-Lewis
next prev parent reply other threads:[~2022-07-12 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 20:52 [PATCH] c: Fix location for _Pragma tokens [PR97498] Lewis Hyatt
2022-07-10 3:58 ` Jeff Law
2022-07-10 20:51 ` Lewis Hyatt
2022-07-11 9:27 ` Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases (was: [PATCH] c: Fix location for _Pragma tokens [PR97498]) Thomas Schwinge
2022-07-12 6:33 ` XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551] (was: Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases) Thomas Schwinge
2022-07-12 11:50 ` Lewis Hyatt [this message]
2022-07-12 13:10 ` Tobias Burnus
2022-07-13 22:30 ` Lewis Hyatt
2022-07-17 15:24 ` [PATCH] c: Fix location for _Pragma tokens [PR97498] Lewis Hyatt
2022-07-31 2:43 ` Jeff Law
2022-07-31 12:44 ` Lewis Hyatt
2022-07-31 15:24 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA_5UQ6i6v+OxyiiVLS3my8x5LsJW3nYkEsgZ1zgqow-2CuLYA@mail.gmail.com \
--to=lhyatt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).