public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: "Christoph Müllner" <christoph.muellner@vrull.eu>
Cc: gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@sifive.com>,
	 Jim Wilson <jim.wilson.gcc@gmail.com>,
	Andrew Waterman <andrew@sifive.com>
Subject: Re: [PATCH 2/2] riscv-cores.def: Add Allwinner D1 core
Date: Wed, 15 Jun 2022 10:39:31 +0200	[thread overview]
Message-ID: <CAAeLtUD8gCU-au7srJeZBj-YJ=tBgSz8=yU_LYiR1RmRFcBTyg@mail.gmail.com> (raw)
In-Reply-To: <CAEg0e7h=NhGwn8WjESS05PERWv559fUioHgcZUmKrdiEp_GJ_g@mail.gmail.com>

On Wed, 15 Jun 2022 at 10:30, Christoph Müllner
<christoph.muellner@vrull.eu> wrote:
>
> On Mon, Jun 13, 2022 at 3:20 PM Christoph Muellner
> <christoph.muellner@vrull.eu> wrote:
> >
> > From: Christoph Müllner <christoph.muellner@vrull.eu>
> >
> > This adds Allwinner's D1 to the list of known cores.
> > The Allwinner includes a single-core XuanTie C906 and is available
> > for quite some time. Note, that the tuning struct for the C906
> > is already part of GCC.
> >
> > gcc/ChangeLog:
> >
> >         * config/riscv/riscv-cores.def (RISCV_CORE): Add "allwinner-d1".
> >
> > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> > ---
> >  gcc/config/riscv/riscv-cores.def | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/gcc/config/riscv/riscv-cores.def b/gcc/config/riscv/riscv-cores.def
> > index 60bcadbb034..dd97ece376f 100644
> > --- a/gcc/config/riscv/riscv-cores.def
> > +++ b/gcc/config/riscv/riscv-cores.def
> > @@ -44,4 +44,6 @@ RISCV_CORE("sifive-s76",      "rv64imafdc", "sifive-7-series")
> >  RISCV_CORE("sifive-u54",      "rv64imafdc", "sifive-5-series")
> >  RISCV_CORE("sifive-u74",      "rv64imafdc", "sifive-7-series")
> >
> > +RISCV_CORE("thead-c906",      "rv64imafdc", "thead-c906")
>
>
> I just realized that this lacks a test case (other -mcpu=... entries have one).
> And the core string is wrong (s/thead-c906/allwinner-d1).
> I will send a v2.

Is the D1 different from the C906? I thought the D1 was using the C906 core?

Philipp.

  reply	other threads:[~2022-06-15  8:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 13:20 [PATCH 1/2] riscv-cores.def: Fix description of RISCV_CORE() macro Christoph Muellner
2022-06-13 13:20 ` [PATCH 2/2] riscv-cores.def: Add Allwinner D1 core Christoph Muellner
2022-06-15  8:30   ` Christoph Müllner
2022-06-15  8:39     ` Philipp Tomsich [this message]
2022-06-15  8:55       ` Christoph Müllner
2022-06-15  8:56         ` Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeLtUD8gCU-au7srJeZBj-YJ=tBgSz8=yU_LYiR1RmRFcBTyg@mail.gmail.com' \
    --to=philipp.tomsich@vrull.eu \
    --cc=andrew@sifive.com \
    --cc=christoph.muellner@vrull.eu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=kito.cheng@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).