Re: [PATCH 2/2] riscv-cores.def: Add Allwinner D1 core

["Christoph Müllner" <christoph.muellner@vrull.eu>]

On Wed, Jun 15, 2022 at 10:39 AM Philipp Tomsich
<philipp.tomsich@vrull.eu> wrote:
>
> On Wed, 15 Jun 2022 at 10:30, Christoph Müllner
> <christoph.muellner@vrull.eu> wrote:
> >
> > On Mon, Jun 13, 2022 at 3:20 PM Christoph Muellner
> > <christoph.muellner@vrull.eu> wrote:
> > >
> > > From: Christoph Müllner <christoph.muellner@vrull.eu>
> > >
> > > This adds Allwinner's D1 to the list of known cores.
> > > The Allwinner includes a single-core XuanTie C906 and is available
> > > for quite some time. Note, that the tuning struct for the C906
> > > is already part of GCC.
> > >
> > > gcc/ChangeLog:
> > >
> > >         * config/riscv/riscv-cores.def (RISCV_CORE): Add "allwinner-d1".
> > >
> > > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> > > ---
> > >  gcc/config/riscv/riscv-cores.def | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/gcc/config/riscv/riscv-cores.def b/gcc/config/riscv/riscv-cores.def
> > > index 60bcadbb034..dd97ece376f 100644
> > > --- a/gcc/config/riscv/riscv-cores.def
> > > +++ b/gcc/config/riscv/riscv-cores.def
> > > @@ -44,4 +44,6 @@ RISCV_CORE("sifive-s76",      "rv64imafdc", "sifive-7-series")
> > >  RISCV_CORE("sifive-u54",      "rv64imafdc", "sifive-5-series")
> > >  RISCV_CORE("sifive-u74",      "rv64imafdc", "sifive-7-series")
> > >
> > > +RISCV_CORE("thead-c906",      "rv64imafdc", "thead-c906")
> >
> >
> > I just realized that this lacks a test case (other -mcpu=... entries have one).
> > And the core string is wrong (s/thead-c906/allwinner-d1).
> > I will send a v2.
>
> Is the D1 different from the C906? I thought the D1 was using the C906 core?

Yes, that's the case.
I'll stick with "thead-c906" as core name for the v2.
Thanks!