public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] Spelling fixes for translatable strings
Date: Tue, 23 Apr 2024 11:32:08 +0100	[thread overview]
Message-ID: <CACb0b4=O4nfDwehr9cp1Qeh-we-PwwpgQ4PSqhEvL_pLBsg9ow@mail.gmail.com> (raw)
In-Reply-To: <ZibW7V2qn+Nt7thB@tucnak>

On Mon, 22 Apr 2024 at 22:30, Jakub Jelinek <jakub@redhat.com> wrote:
>
> Hi!
>
> I've run aspell on gcc.pot (just quickly skimming, so pressing
> I key hundreds of times and just stopping when I catch something that
> looks like a misspelling).
>
> I plan to commit this tomorrow as obvious unless somebody finds some
> issues in it, you know, I'm not a native English speaker.
> Yes, I know favour is valid UK spelling, but we spell the US way I think.

Yup:
https://gcc.gnu.org/codingconventions.html#Spelling

> I've left some *ise* -> *ize* cases (recognise, initialise), those
> had too many hits, though in translatable strings just 4, so maybe
> worth changing too:
> msgid "recognise the specified suffix as a definition module filename"
> msgid "recognise the specified suffix as implementation and module filenames"
> "initialiser for a dylib."
> msgid "%qE attribute argument %qE is not recognised"

That spelling is explicitly mentioned at the link above, so they
should be "ize" really.

> 2024-04-22  Jakub Jelinek  <jakub@redhat.com>
>
>         * config/epiphany/epiphany.opt (may-round-for-trunc): Spelling fix:
>         floatig -> floating.
>         * config/riscv/riscv.opt (mcsr-check): Spelling fix: CRS -> CSR.
>         * params.opt (-param=ipa-cp-profile-count-base=): Spelling fix:
>         frequncy -> frequency.
> gcc/c-family/
>         * c.opt (Wstrict-flex-arrays): Spelling fix: inproper -> improper.
> gcc/cp/
>         * parser.cc (cp_parser_using_declaration): Spelling fix: favour
>         -> favor.
> gcc/m2/
>         * lang.opt (fuse-list=): Spelling fix: finalializations ->
>         finalizations.

LGTM

+Reviewed-by: Jonathan Wakely <jwakely@redhat.com>


  parent reply	other threads:[~2024-04-23 10:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 21:30 Jakub Jelinek
2024-04-22 22:11 ` Palmer Dabbelt
2024-04-23 10:32 ` Jonathan Wakely [this message]
2024-04-23 12:57   ` [committed] Further spelling fixes in " Jakub Jelinek
2024-04-24 14:25     ` Gaius Mulley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4=O4nfDwehr9cp1Qeh-we-PwwpgQ4PSqhEvL_pLBsg9ow@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).