Re: [PATCH] Spelling fixes for translatable strings

[Palmer Dabbelt <palmer@dabbelt.com>]

On Mon, 22 Apr 2024 14:30:21 PDT (-0700), jakub@redhat.com wrote:
> Hi!
>
> I've run aspell on gcc.pot (just quickly skimming, so pressing
> I key hundreds of times and just stopping when I catch something that
> looks like a misspelling).
>
> I plan to commit this tomorrow as obvious unless somebody finds some
> issues in it, you know, I'm not a native English speaker.
> Yes, I know favour is valid UK spelling, but we spell the US way I think.
> I've left some *ise* -> *ize* cases (recognise, initialise), those
> had too many hits, though in translatable strings just 4, so maybe
> worth changing too:
> msgid "recognise the specified suffix as a definition module filename"
> msgid "recognise the specified suffix as implementation and module filenames"
> "initialiser for a dylib."
> msgid "%qE attribute argument %qE is not recognised"
>
> 2024-04-22  Jakub Jelinek  <jakub@redhat.com>
>
> 	* config/epiphany/epiphany.opt (may-round-for-trunc): Spelling fix:
> 	floatig -> floating.
> 	* config/riscv/riscv.opt (mcsr-check): Spelling fix: CRS -> CSR.
> 	* params.opt (-param=ipa-cp-profile-count-base=): Spelling fix:
> 	frequncy -> frequency.
> gcc/c-family/
> 	* c.opt (Wstrict-flex-arrays): Spelling fix: inproper -> improper.
> gcc/cp/
> 	* parser.cc (cp_parser_using_declaration): Spelling fix: favour
> 	-> favor.
> gcc/m2/
> 	* lang.opt (fuse-list=): Spelling fix: finalializations ->
> 	finalizations.
>
> --- gcc/config/epiphany/epiphany.opt.jj	2024-01-03 11:51:47.489509710 +0100
> +++ gcc/config/epiphany/epiphany.opt	2024-04-22 22:53:56.581549745 +0200
> @@ -105,7 +105,7 @@ Enum(attr_fp_mode) String(int) Value(FP_
>
>  may-round-for-trunc
>  Target Mask(MAY_ROUND_FOR_TRUNC)
> -A floatig point to integer truncation may be replaced with rounding to save mode switching.
> +A floating point to integer truncation may be replaced with rounding to save mode switching.
>
>  mvect-double
>  Target Mask(VECT_DOUBLE)
> --- gcc/config/riscv/riscv.opt.jj	2024-04-09 08:12:29.379449739 +0200
> +++ gcc/config/riscv/riscv.opt	2024-04-22 22:52:06.780080712 +0200
> @@ -152,7 +152,7 @@ required to materialize symbol addresses
>
>  mcsr-check
>  Target Var(riscv_mcsr_check) Init(0)
> -Enable the CSR checking for the ISA-dependent CRS and the read-only CSR.
> +Enable the CSR checking for the ISA-dependent CSR and the read-only CSR.
>  The ISA-dependent CSR are only valid when the specific ISA is set.  The
>  read-only CSR can not be written by the CSR instructions.

This came up on IRC.

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>

In case you want to merge it with the rest of thus, but I think it 
should be something more like

    mcsr-check
    Target Var(riscv_mcsr_check) Init(0)
    Turn on (or off) stricter checking for CSR accesses.  With CSR 
    checking enabled a warning will be raised when a CSR access that is 
    not allowed by the currently enabled ISA is performed.  Checks 
    include writing a read-only CSR, and accessing a CSR that requires a 
    currently disabled base ISA or extension.  CSR checking is performed 
    at assembler-time, see the assembler documentation for more 
    information.

I can send that along later if you merge this, no big deal either way on 
my end.  Looks like the binutils docs are the same, so we should updote 
those as well...

Thanks!

> --- gcc/cp/parser.cc.jj	2024-04-22 18:12:35.326282135 +0200
> +++ gcc/cp/parser.cc	2024-04-22 23:14:11.928605442 +0200
> @@ -22431,7 +22431,7 @@ cp_parser_using_declaration (cp_parser*
>    if (access_declaration_p && errorcount == oldcount)
>      warning_at (diag_token->location, OPT_Wdeprecated,
>  		"access declarations are deprecated "
> -		"in favour of using-declarations; "
> +		"in favor of using-declarations; "
>  		"suggestion: add the %<using%> keyword");
>
>    return true;
> --- gcc/m2/lang.opt.jj	2024-04-03 09:58:33.538770735 +0200
> +++ gcc/m2/lang.opt	2024-04-22 22:47:59.120533842 +0200
> @@ -260,7 +260,7 @@ optimize non var unbounded parameters by
>
>  fuse-list=
>  Modula-2 Joined
> -orders the initialization/finalializations for scaffold-static or force linking of modules if scaffold-dynamic
> +orders the initialization/finalizations for scaffold-static or force linking of modules if scaffold-dynamic
>
>  fversion
>  Modula-2
> --- gcc/c-family/c.opt.jj	2024-04-15 10:16:58.571245875 +0200
> +++ gcc/c-family/c.opt	2024-04-22 22:41:48.188705755 +0200
> @@ -1320,7 +1320,7 @@ C ObjC C++ ObjC++ LangEnabledBy(C ObjC C
>
>  Wstrict-flex-arrays
>  C C++ Var(warn_strict_flex_arrays) Warning
> -Warn about inproper usages of flexible array members
> +Warn about improper usages of flexible array members
>  according to the level of -fstrict-flex-arrays.
>
>  Wstrict-null-sentinel
> --- gcc/params.opt.jj	2024-01-03 11:51:22.563855655 +0100
> +++ gcc/params.opt	2024-04-22 23:06:47.466804309 +0200
> @@ -263,7 +263,7 @@ Maximum size of a list of values associa
>
>  -param=ipa-cp-profile-count-base=
>  Common Joined UInteger Var(param_ipa_cp_profile_count_base) Init(10) IntegerRange(0, 100) Param Optimization
> -When using profile feedback, use the edge at this percentage position in frequncy histogram as the bases for IPA-CP heuristics.
> +When using profile feedback, use the edge at this percentage position in frequency histogram as the bases for IPA-CP heuristics.
>
>  -param=ipa-jump-function-lookups=
>  Common Joined UInteger Var(param_ipa_jump_function_lookups) Init(8) Param Optimization
>
> 	Jakub