From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, tromey@adacore.com
Subject: Re: [PATCH] [libstdc++] [prettyprint] add local std::string use to more tests
Date: Fri, 3 Mar 2023 18:09:03 +0000 [thread overview]
Message-ID: <CACb0b4mM9kDHy+dsb+0wbeT4m7EYaJU0Oh3NOHzjany8C2xXTw@mail.gmail.com> (raw)
In-Reply-To: <oro7p9iv1s.fsf@lxoliva.fsfla.org>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Fri, 3 Mar 2023 at 17:50, Alexandre Oliva via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
>
> We're getting regressions after ugprading to GDB 13 in a few of the
> libstdc++ pretty-printing tests. It might seem like a GDB regression,
> but that update has a new symbol reader, and Tom Tromey says it
> exposes a latent problem in the pretty-printer, namely, when a name is
> not defined locally in the local translation unit, GDB will look for
> it in other units, and if multiple different definitions are
> available, there are no guarantees as to which one it will find.
>
> Since libstdc++ contains units in which std::string maps to different
> types, in order to ensure the tests get the std::string definition we
> expect, we need std::string to be present in the debug information for
> the test itself, as we already do in other tests.
>
> Regstrapped on x86_64-linux-gnu. Ok to install?
>
OK, thanks.
prev parent reply other threads:[~2023-03-03 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 17:50 Alexandre Oliva
2023-03-03 18:09 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4mM9kDHy+dsb+0wbeT4m7EYaJU0Oh3NOHzjany8C2xXTw@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).