* Re: [PATCH] libbacktrace: Fix unconditional -Werror
[not found] ` <f5c0649ac7ef0acb685a0c47d82acf069dd2d229.camel@espressif.com>
@ 2023-09-08 10:10 ` Jonathan Wakely
2023-09-08 17:05 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Wakely @ 2023-09-08 10:10 UTC (permalink / raw)
To: Alexey Lapshin
Cc: libstdc++, Jonathan Wakely, Hans-Peter Nilsson, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]
The patch looks good, thanks. I noticed the unconditional -Werror the other
day when testing a build on avr.
N.B. All patches should go to gcc-patches (as well as a more specific list
like libstdc++ when appropriate).
OK for trunk
On Fri, 8 Sept 2023, 10:49 Alexey Lapshin via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
> Added to CC: jwakely@redhat.com, hp@axis.com
>
>
> On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote:
> > -Werror flag should depend on --enable-werror configure option
> >
> > ---
> > libstdc++-v3/src/libbacktrace/Makefile.am | 2 +-
> > libstdc++-v3/src/libbacktrace/Makefile.in | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am
> b/libstdc++-v3/src/libbacktrace/Makefile.am
> > index 9abf9dd64a1..27c1ea570e0 100644
> > --- a/libstdc++-v3/src/libbacktrace/Makefile.am
> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.am
> > @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \
> > $(BACKTRACE_CPPFLAGS)
> >
> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
> > - -Wcast-qual -Werror
> > + -Wcast-qual
> > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes
> -Wold-style-definition -Wno-unused-but-set-variable
> > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter
> > AM_CFLAGS = $(C_WARN_FLAGS)
> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in
> b/libstdc++-v3/src/libbacktrace/Makefile.in
> > index 1c1242d8827..b78c8443751 100644
> > --- a/libstdc++-v3/src/libbacktrace/Makefile.in
> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.in
> > @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@
> > VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@
> > VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@
> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
> > - -Wcast-qual -Werror
> > + -Wcast-qual
> >
> > XMLCATALOG = @XMLCATALOG@
> > XMLLINT = @XMLLINT@
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libbacktrace: Fix unconditional -Werror
2023-09-08 10:10 ` [PATCH] libbacktrace: Fix unconditional -Werror Jonathan Wakely
@ 2023-09-08 17:05 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2023-09-08 17:05 UTC (permalink / raw)
To: Jonathan Wakely
Cc: Alexey Lapshin, libstdc++, Hans-Peter Nilsson, gcc-patches
On Fri, 8 Sept 2023 at 11:10, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>
> The patch looks good, thanks. I noticed the unconditional -Werror the other day when testing a build on avr.
>
> N.B. All patches should go to gcc-patches (as well as a more specific list like libstdc++ when appropriate).
>
> OK for trunk
I've pushed this now - thanks again.
>
>
>
> On Fri, 8 Sept 2023, 10:49 Alexey Lapshin via Libstdc++, <libstdc++@gcc.gnu.org> wrote:
>>
>> Added to CC: jwakely@redhat.com, hp@axis.com
>>
>>
>> On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote:
>> > -Werror flag should depend on --enable-werror configure option
>> >
>> > ---
>> > libstdc++-v3/src/libbacktrace/Makefile.am | 2 +-
>> > libstdc++-v3/src/libbacktrace/Makefile.in | 2 +-
>> > 2 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am b/libstdc++-v3/src/libbacktrace/Makefile.am
>> > index 9abf9dd64a1..27c1ea570e0 100644
>> > --- a/libstdc++-v3/src/libbacktrace/Makefile.am
>> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.am
>> > @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \
>> > $(BACKTRACE_CPPFLAGS)
>> >
>> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
>> > - -Wcast-qual -Werror
>> > + -Wcast-qual
>> > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wno-unused-but-set-variable
>> > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter
>> > AM_CFLAGS = $(C_WARN_FLAGS)
>> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in b/libstdc++-v3/src/libbacktrace/Makefile.in
>> > index 1c1242d8827..b78c8443751 100644
>> > --- a/libstdc++-v3/src/libbacktrace/Makefile.in
>> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.in
>> > @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@
>> > VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@
>> > VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@
>> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
>> > - -Wcast-qual -Werror
>> > + -Wcast-qual
>> >
>> > XMLCATALOG = @XMLCATALOG@
>> > XMLLINT = @XMLLINT@
>>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-08 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <0784b8c8a8149b672e01ad9da657f6cbf9df7227.camel@espressif.com>
[not found] ` <f5c0649ac7ef0acb685a0c47d82acf069dd2d229.camel@espressif.com>
2023-09-08 10:10 ` [PATCH] libbacktrace: Fix unconditional -Werror Jonathan Wakely
2023-09-08 17:05 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).