From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] [libstdc++] [testsuite] xfail to_chars/long_double on x86-vxworks
Date: Wed, 24 May 2023 09:35:09 +0100 [thread overview]
Message-ID: <CACb0b4mxfccRtbWSf2Rf9R_E0uca9KhHnPNif=1KRMrwav-=oQ@mail.gmail.com> (raw)
In-Reply-To: <or5y8ip9ba.fsf@lxoliva.fsfla.org>
[-- Attachment #1: Type: text/plain, Size: 1667 bytes --]
On Wed, 24 May 2023 at 06:52, Alexandre Oliva via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
>
> Just as on aarch64, x86's wider long double experiences loss of
> precision with from_chars implemented in terms of double. Expect the
> execution fail.
>
> Bootstrapped on x86_64-linux-gnu. Also tested on ppc- and x86-vx7r2
> with gcc-12.
>
OK for trunk and branches.
>
> for libstdc++-v3/ChangeLog
>
> * testsuite/20_util/to_chars/long_double.cc: Expect execution
> fail on x86-vxworks.
> ---
> .../testsuite/20_util/to_chars/long_double.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> b/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> index 263144bd42cba..08363d9d04003 100644
> --- a/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> +++ b/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> @@ -36,7 +36,7 @@
>
> // On systems that use double-precision from_chars for long double,
> // this is expected to fail.
> -// { dg-xfail-run-if "from_chars limited to double-precision" {
> aarch64-*-vxworks* } }
> +// { dg-xfail-run-if "from_chars limited to double-precision" {
> aarch64-*-vxworks* i*86-*-vxworks* } }
>
> // { dg-require-effective-target ieee_floats }
> // { dg-require-effective-target size32plus }
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
>
>
prev parent reply other threads:[~2023-05-24 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 5:50 Alexandre Oliva
2023-05-24 8:35 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4mxfccRtbWSf2Rf9R_E0uca9KhHnPNif=1KRMrwav-=oQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).