public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] [libstdc++] [testsuite] xfail to_chars/long_double on x86-vxworks
@ 2023-05-24  5:50 Alexandre Oliva
  2023-05-24  8:35 ` Jonathan Wakely
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2023-05-24  5:50 UTC (permalink / raw)
  To: gcc-patches, libstdc++


Just as on aarch64, x86's wider long double experiences loss of
precision with from_chars implemented in terms of double.  Expect the
execution fail.

Bootstrapped on x86_64-linux-gnu.  Also tested on ppc- and x86-vx7r2
with gcc-12.

for  libstdc++-v3/ChangeLog

	* testsuite/20_util/to_chars/long_double.cc: Expect execution
	fail on x86-vxworks.
---
 .../testsuite/20_util/to_chars/long_double.cc      |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc b/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
index 263144bd42cba..08363d9d04003 100644
--- a/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
+++ b/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
@@ -36,7 +36,7 @@
 
 // On systems that use double-precision from_chars for long double,
 // this is expected to fail.
-// { dg-xfail-run-if "from_chars limited to double-precision" { aarch64-*-vxworks* } }
+// { dg-xfail-run-if "from_chars limited to double-precision" { aarch64-*-vxworks* i*86-*-vxworks* } }
 
 // { dg-require-effective-target ieee_floats }
 // { dg-require-effective-target size32plus }

-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [libstdc++] [testsuite] xfail to_chars/long_double on x86-vxworks
  2023-05-24  5:50 [PATCH] [libstdc++] [testsuite] xfail to_chars/long_double on x86-vxworks Alexandre Oliva
@ 2023-05-24  8:35 ` Jonathan Wakely
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2023-05-24  8:35 UTC (permalink / raw)
  To: Alexandre Oliva; +Cc: gcc-patches, libstdc++

[-- Attachment #1: Type: text/plain, Size: 1667 bytes --]

On Wed, 24 May 2023 at 06:52, Alexandre Oliva via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:

>
> Just as on aarch64, x86's wider long double experiences loss of
> precision with from_chars implemented in terms of double.  Expect the
> execution fail.
>
> Bootstrapped on x86_64-linux-gnu.  Also tested on ppc- and x86-vx7r2
> with gcc-12.
>

OK for trunk and branches.



>
> for  libstdc++-v3/ChangeLog
>
>         * testsuite/20_util/to_chars/long_double.cc: Expect execution
>         fail on x86-vxworks.
> ---
>  .../testsuite/20_util/to_chars/long_double.cc      |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> b/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> index 263144bd42cba..08363d9d04003 100644
> --- a/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> +++ b/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc
> @@ -36,7 +36,7 @@
>
>  // On systems that use double-precision from_chars for long double,
>  // this is expected to fail.
> -// { dg-xfail-run-if "from_chars limited to double-precision" {
> aarch64-*-vxworks* } }
> +// { dg-xfail-run-if "from_chars limited to double-precision" {
> aarch64-*-vxworks* i*86-*-vxworks* } }
>
>  // { dg-require-effective-target ieee_floats }
>  // { dg-require-effective-target size32plus }
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-24  8:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-24  5:50 [PATCH] [libstdc++] [testsuite] xfail to_chars/long_double on x86-vxworks Alexandre Oliva
2023-05-24  8:35 ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).