From: Jonathan Wakely <jwakely@redhat.com>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Skip integer division optimization for Clang
Date: Tue, 21 Mar 2023 17:12:37 +0000 [thread overview]
Message-ID: <CACb0b4ndZ7y1JkhFHkO0ZBYsNgcuj=EcTnOVnFuSFPF+P8LSFw@mail.gmail.com> (raw)
In-Reply-To: <7568297.R56niFO833@minbar>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Tue, 21 Mar 2023 at 17:06, Matthias Kretz via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
> Tested on x86_64-pc-linux-gnu.
>
> --------- 8< -----------
>
> Clang ICEs on _SimdImplX86::_S_divides. The function is only working
> around a missed optimization and not necessary for correctness.
> Therefore, don't use it for Clang.
>
> Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
>
> libstdc++-v3/ChangeLog:
>
> * include/experimental/bits/simd_detail.h: Don't define
> _GLIBCXX_SIMD_WORKAROUND_PR90993 for Clang.
> * include/experimental/bits/simd_x86.h (_S_divides): Remove
> check for __clang__.
OK
prev parent reply other threads:[~2023-03-21 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 17:05 Matthias Kretz
2023-03-21 17:12 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4ndZ7y1JkhFHkO0ZBYsNgcuj=EcTnOVnFuSFPF+P8LSFw@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=m.kretz@gsi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).