From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_Hashtable] Add missing destructor call
Date: Mon, 6 Nov 2023 23:28:51 +0000 [thread overview]
Message-ID: <CACb0b4niVWwhNyFGHnV2DgqD4AoDf4wO=MAETbomWRz4Z-tjyQ@mail.gmail.com> (raw)
In-Reply-To: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com>
On Mon, 6 Nov 2023 at 21:39, François Dumont <frs.dumont@gmail.com> wrote:
>
> Noticed looking for other occasion to replace __try/__catch with RAII
> helper.
>
> libstdc++: [_Hashtable] Add missing node destructor call
>
> libstdc++-v3/ChangeLog:
>
> * include/bits/hashtable_policy.h
> (_Hashtable_alloc<>::_M_allocate_node): Add missing call to
> node destructor
> on construct exception.
>
> Tested under Linux x64, ok to commit ?
OK.
Is this missing on any branches too?
I don't think it's actually a problem, since it's a trivial destructor anyway.
>
> I hope gmail appli will appreciate .diff instead of .patch. .txt are not
> in .gitignore so annoying to use for patches.
>
> François
next prev parent reply other threads:[~2023-11-06 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 21:38 François Dumont
2023-11-06 21:58 ` Sam James
2023-11-06 23:13 ` Jonathan Wakely
2023-11-06 23:28 ` Jonathan Wakely [this message]
2023-11-08 5:39 ` François Dumont
2023-11-08 14:26 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4niVWwhNyFGHnV2DgqD4AoDf4wO=MAETbomWRz4Z-tjyQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).