From: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
To: gcc-patches@gcc.gnu.org
Cc: Bernd Schmidt <bernds_cb1@t-online.de>,
Vladimir Makarov <vmakarov@redhat.com>,
Jeff Law <jeffreyalaw@gmail.com>,
Alexander Monakov <amonakov@ispras.ru>,
Richard Guenther <richard.guenther@gmail.com>
Subject: Re: [PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists().
Date: Mon, 15 Jan 2024 17:01:27 +0400 [thread overview]
Message-ID: <CAD0Vn-CHyXu2p4_O1_jgkU87UE=nN3v2WLr7m0CQOjvNt2zd1g@mail.gmail.com> (raw)
In-Reply-To: <20231122111415.815147-5-maxim.kuvyrkov@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3083 bytes --]
Dear scheduler maintainers,
Gentle ping. This patch is borderline trivial and affects only the lucky
few who debug sched-deps.cc code. OK to merge?
On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
wrote:
> Better propagate flags from dump_lists() into dump_dep() and
> add a missing "]" in dump_lists().
>
> gcc/ChangeLog:
>
> * sched-deps.cc (DUMP_DEP_PRO): Improve comment.
> (dump_dep_flags): Remove.
> (DUMP_LISTS_SIZE, DUMP_LISTS_DEPS, DUMP_LISTS_ALL): Continue
> numbering from DUMP_DEP_* flags.
> (dump_lists): Update and fix.
> ---
> gcc/sched-deps.cc | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc
> index 005fc0f567e..4d357079a7a 100644
> --- a/gcc/sched-deps.cc
> +++ b/gcc/sched-deps.cc
> @@ -132,7 +132,8 @@ static void dump_ds (FILE *, ds_t);
> /* Define flags for dump_dep (). */
>
> /* Dump producer of the dependence. */
> -#define DUMP_DEP_PRO (2)
> +#define DUMP_DEP_PRO (2) /* Reserve "1" for handling of DUMP_DEP_ALL and
> + DUMP_LISTS_ALL. */
>
> /* Dump consumer of the dependence. */
> #define DUMP_DEP_CON (4)
> @@ -206,9 +207,6 @@ dump_dep (FILE *dump, dep_t dep, int flags)
> fprintf (dump, ">");
> }
>
> -/* Default flags for dump_dep (). */
> -static int dump_dep_flags = (DUMP_DEP_PRO | DUMP_DEP_CON);
> -
> /* Dump all fields of DEP to STDERR. */
> void
> sd_debug_dep (dep_t dep)
> @@ -1454,19 +1452,20 @@ sd_delete_dep (sd_iterator_def sd_it)
> }
>
> /* Dump size of the lists. */
> -#define DUMP_LISTS_SIZE (2)
> +#define DUMP_LISTS_SIZE (32) /* (DUMP_DEP_STATUS << 1) */
>
> /* Dump dependencies of the lists. */
> -#define DUMP_LISTS_DEPS (4)
> +#define DUMP_LISTS_DEPS (64)
>
> /* Dump all information about the lists. */
> #define DUMP_LISTS_ALL (DUMP_LISTS_SIZE | DUMP_LISTS_DEPS)
>
> /* Dump deps_lists of INSN specified by TYPES to DUMP.
> - FLAGS is a bit mask specifying what information about the lists needs
> - to be printed.
> + FLAGS is a bit mask specifying what information about the lists and
> + the individual deps needs to be printed, this is a combination of
> + DUMP_DEP_* and DUMP_LISTS_* flags.
> If FLAGS has the very first bit set, then dump all information about
> - the lists and propagate this bit into the callee dump functions. */
> + the lists and deps propagate this bit into the callee dump functions.
> */
> static void
> dump_lists (FILE *dump, rtx insn, sd_list_types_def types, int flags)
> {
> @@ -1488,10 +1487,12 @@ dump_lists (FILE *dump, rtx insn,
> sd_list_types_def types, int flags)
> {
> FOR_EACH_DEP (insn, types, sd_it, dep)
> {
> - dump_dep (dump, dep, dump_dep_flags | all);
> + dump_dep (dump, dep, flags | all);
> fprintf (dump, " ");
> }
> }
> +
> + fprintf (dump, "]");
> }
>
> /* Dump all information about deps_lists of INSN specified by TYPES
> --
> 2.34.1
>
>
--
Maxim Kuvyrkov
www.linaro.org
next prev parent reply other threads:[~2024-01-15 13:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 12:06 [PATCH 0/1] Avoid exponential behavior in scheduler and better logging Maxim Kuvyrkov
2023-11-20 12:06 ` [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior Maxim Kuvyrkov
2023-11-20 13:09 ` Richard Biener
2023-11-20 13:42 ` Maxim Kuvyrkov
2023-11-20 13:45 ` Richard Biener
2023-11-20 14:48 ` [PATCH v2] " Maxim Kuvyrkov
2023-11-20 18:59 ` [PATCH 1/1] " Maxim Kuvyrkov
2023-11-20 13:52 ` Alexander Monakov
2023-11-20 14:39 ` Maxim Kuvyrkov
2023-11-20 16:30 ` Alexander Monakov
2023-11-21 10:32 ` Maxim Kuvyrkov
2023-11-21 11:05 ` Alexander Monakov
2023-11-22 11:14 ` [PATCH v3 0/8] Avoid exponential behavior in scheduler and better logging Maxim Kuvyrkov
2023-11-22 11:14 ` [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior Maxim Kuvyrkov
2024-01-15 12:56 ` Maxim Kuvyrkov
2024-01-15 18:26 ` Vladimir Makarov
2024-01-16 14:52 ` Jeff Law
2024-01-17 6:51 ` Richard Biener
2024-01-17 7:39 ` Maxim Kuvyrkov
2024-01-17 15:02 ` Richard Biener
2024-01-17 15:05 ` Maxim Kuvyrkov
2024-01-17 15:44 ` Maxim Kuvyrkov
2024-01-17 18:54 ` H.J. Lu
2023-11-22 11:14 ` [PATCH v3 2/8] Unify implementations of print_hard_reg_set() Maxim Kuvyrkov
2023-11-22 15:04 ` Vladimir Makarov
2023-11-22 11:14 ` [PATCH v3 3/8] Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc Maxim Kuvyrkov
2024-01-15 12:59 ` Maxim Kuvyrkov
2023-11-22 11:14 ` [PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists() Maxim Kuvyrkov
2024-01-15 13:01 ` Maxim Kuvyrkov [this message]
2023-11-22 11:14 ` [PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis Maxim Kuvyrkov
2024-01-15 13:04 ` Maxim Kuvyrkov
2023-11-22 11:14 ` [PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts Maxim Kuvyrkov
2024-01-15 13:05 ` Maxim Kuvyrkov
2023-11-22 11:14 ` [PATCH v3 7/8] Improve logging of register data in scheduler dependency analysis Maxim Kuvyrkov
2024-01-15 13:06 ` Maxim Kuvyrkov
2023-11-22 11:14 ` [PATCH v3 8/8] Improve logging of scheduler dependency analysis context Maxim Kuvyrkov
2024-01-15 13:08 ` Maxim Kuvyrkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD0Vn-CHyXu2p4_O1_jgkU87UE=nN3v2WLr7m0CQOjvNt2zd1g@mail.gmail.com' \
--to=maxim.kuvyrkov@linaro.org \
--cc=amonakov@ispras.ru \
--cc=bernds_cb1@t-online.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).