From: NightStrike <nightstrike@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR target/90458
Date: Fri, 17 Feb 2023 03:56:18 -0500 [thread overview]
Message-ID: <CAF1jjLv=AygrS-6sD3v-rfD8vak_M9pLjDz94O_O27Ex+3OCpA@mail.gmail.com> (raw)
In-Reply-To: <5906630.lOV4Wx5bFT@fomalhaut>
On Thu, Feb 16, 2023 at 3:16 AM Eric Botcazou <botcazou@adacore.com> wrote:
>
> > This fixes dg.exp/stack-check-2.c, -7, 8, and -16.c, which is great!
>
> Try the attached patch.
Well... that patch just marks all of the tests as unsupported. But
for example, the ones quoted above run, work, and pass. And when they
didn't pass, they highlighted the ICE that you fixed. So running the
test despite the nature of stack protection on Windows still has
value. It is useful to ensure for example that stack protection
continues to work even if options are passed to disable it. But the
tests that remain are looking for rtl patterns that (I assume)
shouldn't exist. So it's perhaps useful to modify the test to say
that on windows, the scan-rtl-dump-times check should have zero hits.
If it found a match, that would be an error.
Is there a way to say that the test results should be inverted on a
particular platform (instead of purely unsupported)?
next prev parent reply other threads:[~2023-02-17 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 15:24 Eric Botcazou
2023-02-15 19:05 ` Jeff Law
2023-02-16 3:27 ` NightStrike
2023-02-16 8:16 ` Eric Botcazou
2023-02-17 8:56 ` NightStrike [this message]
2023-02-17 9:18 ` Eric Botcazou
2023-02-17 19:49 ` Jeff Law
2023-03-11 15:56 ` Jeff Law
2023-03-12 0:35 ` NightStrike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF1jjLv=AygrS-6sD3v-rfD8vak_M9pLjDz94O_O27Ex+3OCpA@mail.gmail.com' \
--to=nightstrike@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).