From: Uros Bizjak <ubizjak@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Hongtao Liu <hongtao.liu@intel.com>
Subject: Re: [PATCH] testsuite/ix86: SSE2 is a prereq to _Float16 use
Date: Tue, 28 Jun 2022 08:53:20 +0200 [thread overview]
Message-ID: <CAFULd4Yd-X+VgXugNMrmLdATvOcutXDLvDa7Mkg=Q_8HJxLmfA@mail.gmail.com> (raw)
In-Reply-To: <f3b2de01-c5c9-19dd-96bc-1cdd81240121@suse.com>
On Tue, Jun 28, 2022 at 8:49 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> When enabling AVX512FP via attribute or pragma, the _Float16 type would
> remain unavailable when at initialization time SSE2 wouldn't be seen as
> available for use. While this may hint at a wider underlying issue (like
> the feature, the type may want providing dynamically, albeit this may be
> challenging in particular for functions returning _Float16 yet having
> the attribute specified after their return type), for now simply make
> SSE2 available when targeting ix86.
>
> gcc/testsuite/
>
> * gcc.target/i386/avx512fp16-reduce-op-2.c: Force SSE2 for i?86.
> * gcc.target/i386/pr99464.c: Likewise.
OK.
Thanks,
Uros.
>
> --- a/gcc/testsuite/gcc.target/i386/avx512fp16-reduce-op-2.c
> +++ b/gcc/testsuite/gcc.target/i386/avx512fp16-reduce-op-2.c
> @@ -1,5 +1,6 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mprefer-vector-width=512 -fdump-tree-optimized" } */
> +/* { dg-additional-options "-msse2" { target i?86-*-* } } */
>
> /* { dg-final { scan-tree-dump-times "\.REDUC_PLUS" 3 "optimized" } } */
> /* { dg-final { scan-tree-dump-times "\.REDUC_MIN" 3 "optimized" } } */
> --- a/gcc/testsuite/gcc.target/i386/pr99464.c
> +++ b/gcc/testsuite/gcc.target/i386/pr99464.c
> @@ -1,6 +1,7 @@
> /* PR target/99464 */
> /* { dg-do compile } */
> /* { dg-options "-O2" } */
> +/* { dg-additional-options "-msse2" { target i?86-*-* } } */
>
> #pragma GCC target("arch=cannonlake")
>
prev parent reply other threads:[~2022-06-28 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 6:49 Jan Beulich
2022-06-28 6:53 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Yd-X+VgXugNMrmLdATvOcutXDLvDa7Mkg=Q_8HJxLmfA@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hubicka@ucw.cz \
--cc=jbeulich@suse.com \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).