From: Uros Bizjak <ubizjak@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] [testsuite] [x86] cope with --enable-frame-pointer
Date: Wed, 24 May 2023 08:31:23 +0200 [thread overview]
Message-ID: <CAFULd4YxNGHY9zg1FWu-+NVw7HB2c=CLJwJq2z=QUcc7Qpg5yA@mail.gmail.com> (raw)
In-Reply-To: <ora5xup9e3.fsf@lxoliva.fsfla.org>
On Wed, May 24, 2023 at 7:48 AM Alexandre Oliva <oliva@adacore.com> wrote:
>
>
> Various x86 tests fail if the toolchain is configured with
> --enable-frame-pointer, because the unexpected extra insns mess with
> the expected asm counts. Add -fomit-frame-pointer so that they can
> still pass.
>
> Bootstrapped on x86_64-linux-gnu. Also tested on ppc- and x86-vx7r2
> with gcc-12.
>
> for gcc/testsuite/ChangeLog
>
> * gcc.target/i386/pieces-memcpy-7.c: Add -fomit-frame-pointer.
> * gcc.target/i386/pieces-memcpy-8.c: Likewise.
> * gcc.target/i386/pieces-memcpy-9.c: Likewise.
> * gcc.target/i386/pieces-memset-1.c: Likewise.
> * gcc.target/i386/pieces-memset-36.c: Likewise.
> * gcc.target/i386/pieces-memset-4.c: Likewise.
> * gcc.target/i386/pieces-memset-40.c: Likewise.
> * gcc.target/i386/pieces-memset-41.c: Likewise.
> * gcc.target/i386/pieces-memset-7.c: Likewise.
> * gcc.target/i386/pieces-memset-8.c: Likewise.
> * gcc.target/i386/pieces-memset-9.c: Likewise.
> * gcc.target/i386/pr102230.c: Likewise.
> * gcc.target/i386/pr78103-2.c: Likewise.
OK.
Thanks,
Uros.
> ---
> gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-1.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-36.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-4.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-40.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-41.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-7.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-8.c | 2 ++
> gcc/testsuite/gcc.target/i386/pieces-memset-9.c | 2 ++
> gcc/testsuite/gcc.target/i386/pr102230.c | 2 ++
> gcc/testsuite/gcc.target/i386/pr78103-2.c | 2 ++
> 13 files changed, 26 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c b/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c
> index 3d248d447ea42..64fd8b4176cec 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memcpy-7.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx -msse2 -mtune=generic" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> void
> foo (int a1, int a2, int a3, int a4, int a5, int a6, char *dst, char *src)
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c b/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c
> index c13a2beb2f017..fc60c46c58900 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memcpy-8.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx2 -mavx -mtune=generic" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> void
> foo (int a1, int a2, int a3, int a4, int a5, int a6, char *dst, char *src)
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c b/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c
> index 238f88b275eb7..62fcb6f569204 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memcpy-9.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mavx512f -mtune=generic" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> void
> foo (int a1, int a2, int a3, int a4, int a5, int a6, char *dst, char *src)
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-1.c b/gcc/testsuite/gcc.target/i386/pieces-memset-1.c
> index f7487ba9c5b28..0002c6838ab76 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-1.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-1.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx -msse2 -mtune=generic -mno-stackrealign" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-36.c b/gcc/testsuite/gcc.target/i386/pieces-memset-36.c
> index d1f1263c7b211..d1bbfa204a7f8 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-36.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-36.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx512f -mavx2 -mtune=generic" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-4.c b/gcc/testsuite/gcc.target/i386/pieces-memset-4.c
> index a12b9dda28bd3..8b3f3b00214f8 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-4.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-4.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx -msse2 -mtune=generic -mno-stackrealign" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-40.c b/gcc/testsuite/gcc.target/i386/pieces-memset-40.c
> index 4eda73ead5924..37a9dcc8c1ea8 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-40.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-40.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx512f -mavx2 -mtune=sandybridge" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-41.c b/gcc/testsuite/gcc.target/i386/pieces-memset-41.c
> index 93df8101e4d0f..d7a27f52983fa 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-41.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-41.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx2 -mavx -mtune=sandybridge -mno-stackrealign" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-7.c b/gcc/testsuite/gcc.target/i386/pieces-memset-7.c
> index 0d02877f67b33..56be2991ba63e 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-7.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-7.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx -msse2 -mtune=generic -mno-stackrealign" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-8.c b/gcc/testsuite/gcc.target/i386/pieces-memset-8.c
> index 816d83ea027cf..e4e63b855bcfe 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-8.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-8.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-avx2 -mavx -mtune=generic -mno-stackrealign" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-9.c b/gcc/testsuite/gcc.target/i386/pieces-memset-9.c
> index 1ead154fe1ed6..d64cf6b464893 100644
> --- a/gcc/testsuite/gcc.target/i386/pieces-memset-9.c
> +++ b/gcc/testsuite/gcc.target/i386/pieces-memset-9.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -march=x86-64 -mavx512f -mtune=generic" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> extern char *dst;
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr102230.c b/gcc/testsuite/gcc.target/i386/pr102230.c
> index ad37f4f265a9c..2f0fe5268a7e6 100644
> --- a/gcc/testsuite/gcc.target/i386/pr102230.c
> +++ b/gcc/testsuite/gcc.target/i386/pr102230.c
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -mavx512fp16" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
>
> typedef _Float16 v4hf __attribute__ ((vector_size (8)));
> typedef _Float16 v2hf __attribute__ ((vector_size (4)));
> diff --git a/gcc/testsuite/gcc.target/i386/pr78103-2.c b/gcc/testsuite/gcc.target/i386/pr78103-2.c
> index 30f7f98f60a41..0183554389f16 100644
> --- a/gcc/testsuite/gcc.target/i386/pr78103-2.c
> +++ b/gcc/testsuite/gcc.target/i386/pr78103-2.c
> @@ -1,6 +1,8 @@
> /* PR target/78103 */
> /* { dg-do compile } */
> /* { dg-options "-O2 -mno-lzcnt" } */
> +/* Cope with --enable-frame-pointer. */
> +/* { dg-additional-options "-fomit-frame-pointer" } */
> /* { dg-final { scan-assembler-not {\mmovl\M} } } */
> /* { dg-final { scan-assembler-not {\mxor[lq]\M} } } */
> /* { dg-final { scan-assembler-not {\msubl\M} } } */
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
prev parent reply other threads:[~2023-05-24 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 5:48 Alexandre Oliva
2023-05-24 6:31 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4YxNGHY9zg1FWu-+NVw7HB2c=CLJwJq2z=QUcc7Qpg5yA@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).