From: Uros Bizjak <ubizjak@gmail.com>
To: Sergei Trofimovich <slyich@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Sergei Trofimovich <siarheit@google.com>
Subject: Re: PING [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc
Date: Mon, 3 Oct 2022 22:41:30 +0200 [thread overview]
Message-ID: <CAFULd4Z=3321fgu0wNG=oP_3w_YBkkK=zPvDj9Uv2jLNHPeUNg@mail.gmail.com> (raw)
In-Reply-To: <20221003080456.258fa375@nz>
On Mon, Oct 3, 2022 at 9:05 AM Sergei Trofimovich via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Thu, 22 Sep 2022 22:07:52 +0100
> Sergei Trofimovich <slyich@gmail.com> wrote:
>
> > On Fri, 16 Sept 2022 at 19:49, Sergei Trofimovich <slyich@gmail.com> wrote:
> > >
> > > From: Sergei Trofimovich <siarheit@google.com>
> > >
> > > i386-builtin-types.inc is included indirectly via i386-builtins.h
> > > into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc
> > >
> > > Only i386.cc dependency was present in gcc/config/t-i386 makefile.
> > >
> > > As a result parallel builds occasionally fail as:
> > >
> > > g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc
> > > In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92:
> > > ../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10:
> > > fatal error: i386-builtin-types.inc: No such file or directory
> > > 25 | #include "i386-builtin-types.inc"
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> > > make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o]
> > > Error 1 shuffle=1663349189
> > >
> > > gcc/
> > > * config/i386/t-i386: Add build-time dependencies against
> > > i386-builtin-types.inc to i386-builtins.o, i386-expand.o,
> > > i386-features.o.
OK.
Thanks,
Uros.
> > > ---
> > > gcc/config/i386/t-i386 | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386
> > > index 4e2a0efc615..ffdbbdfe8ce 100644
> > > --- a/gcc/config/i386/t-i386
> > > +++ b/gcc/config/i386/t-i386
> > > @@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc
> > > $(COMPILE) $<
> > > $(POSTCOMPILE)
> > >
> > > +# i386-builtin-types.inc is included into i386-builtins.h.
> > > +# Below are direct users of i386-builtins.h:
> > > i386.o: i386-builtin-types.inc
> > > +i386-builtins.o: i386-builtin-types.inc
> > > +i386-expand.o: i386-builtin-types.inc
> > > +i386-features.o: i386-builtin-types.inc
> > >
> > > i386-builtin-types.inc: s-i386-bt ; @true
> > > s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \
> > > --
> > > 2.37.2
> > >
> >
> > Is it a reasonable approach? Maybe gcc has an equivalent of automake's
> > BUILT_SOURCES to avoid explicit tracking of such dependencies?
> >
> > --
> > Sergei
>
>
> --
>
> Sergei
prev parent reply other threads:[~2022-10-03 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 18:49 Sergei Trofimovich
2022-09-22 21:07 ` Sergei Trofimovich
2022-10-03 7:04 ` PING " Sergei Trofimovich
2022-10-03 20:41 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Z=3321fgu0wNG=oP_3w_YBkkK=zPvDj9Uv2jLNHPeUNg@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=siarheit@google.com \
--cc=slyich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).