From: Uros Bizjak <ubizjak@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [x86 PATCH] Standardize shift amount constants as QImode.
Date: Sun, 18 Jun 2023 13:18:06 +0200 [thread overview]
Message-ID: <CAFULd4ZDcB_SSgzxf64ArZLC2TTBOK=tQn7Dn7GMEj9hR0RWkw@mail.gmail.com> (raw)
In-Reply-To: <005501d9a1c4$1443cd30$3ccb6790$@nextmovesoftware.com>
On Sun, Jun 18, 2023 at 11:05 AM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This clean-up improves consistency within i386.md by using QImode for
> the constant shift count in patterns that specify a mode.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=unix{-m32}
> with no new failures. Ok for mainline?
>
>
> 2023-06-18 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> * config/i386/i386.md (*concat<mode><dwi>3_1): Use QImode
> for the immediate constant shift count.
> (*concat<mode><dwi>3_2): Likewise.
> (*concat<mode><dwi>3_3): Likewise.
> (*concat<mode><dwi>3_4): Likewise.
> (*concat<mode><dwi>3_5): Likewise.
> (*concat<mode><dwi>3_6): Likewise.
OK.
Thanks,
Uros.
>
>
> Thanks,
> Roger
> --
>
>
prev parent reply other threads:[~2023-06-18 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 9:05 Roger Sayle
2023-06-18 11:18 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4ZDcB_SSgzxf64ArZLC2TTBOK=tQn7Dn7GMEj9hR0RWkw@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).