From: Uros Bizjak <ubizjak@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [x86 PATCH] Refactor new ix86_expand_carry to set the carry flag.
Date: Sun, 18 Jun 2023 13:19:06 +0200 [thread overview]
Message-ID: <CAFULd4ZjtWf4YuddjsBaOF45XXeJm-z=ZZeHUeYGExwsiRuXQA@mail.gmail.com> (raw)
In-Reply-To: <000f01d9a1d5$6d676960$48363c20$@nextmovesoftware.com>
On Sun, Jun 18, 2023 at 1:10 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch refactors the three places in the i386.md backend that we
> set the carry flag into a new ix86_expand_carry helper function, that
> allows Jakub's recently added uaddc<mode>5 and usubc<mode>5 expanders
> to take advantage of the recently added support for the stc instruction.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=unix{-m32}
> with no new failures. Ok for mainline?
>
>
> 2023-06-18 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> * config/i386/i386-expand.cc (ix86_expand_carry): New helper
> function for setting the carry flag.
> (ix86_expand_builtin) <handlecarry>: Use it here.
> * config/i386/i386-protos.h (ix86_expand_carry): Prototype here.
> * config/i386/i386.md (uaddc<mode>5): Use ix86_expand_carry.
> (usubc<mode>5): Likewise.
OK.
Thanks,
Uros.
>
> Thanks in advance,
> Roger
> --
>
prev parent reply other threads:[~2023-06-18 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 11:10 Roger Sayle
2023-06-18 11:19 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4ZjtWf4YuddjsBaOF45XXeJm-z=ZZeHUeYGExwsiRuXQA@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).