* [PATCH] [x86] Fix typo in floorv2sf2, should be register_operand for op1, not vector_operand.
@ 2022-09-22 1:15 liuhongt
2022-09-22 1:22 ` Hongtao Liu
2022-09-22 5:59 ` Uros Bizjak
0 siblings, 2 replies; 3+ messages in thread
From: liuhongt @ 2022-09-22 1:15 UTC (permalink / raw)
To: gcc-patches; +Cc: crazylht, hjl.tools
Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
Verify 526.blend_r can be rebuilt with the fix.
Ok for trunk?
gcc/ChangeLog:
PR target/106994
* config/i386/mmx.md (floorv2sf2): Fix typo, use
register_operand instead of vector_operand for operands[1].
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr106994.c: New test.
---
gcc/config/i386/mmx.md | 2 +-
gcc/testsuite/gcc.target/i386/pr106994.c | 24 ++++++++++++++++++++++++
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/gcc.target/i386/pr106994.c
diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
index 222a041de58..c359e2dd6de 100644
--- a/gcc/config/i386/mmx.md
+++ b/gcc/config/i386/mmx.md
@@ -1676,7 +1676,7 @@ (define_expand "lceilv2sfv2si2"
(define_expand "floorv2sf2"
[(set (match_operand:V2SF 0 "register_operand")
(unspec:V2SF
- [(match_operand:V2SF 1 "vector_operand")
+ [(match_operand:V2SF 1 "register_operand")
(match_dup 2)]
UNSPEC_ROUND))]
"TARGET_SSE4_1 && !flag_trapping_math
diff --git a/gcc/testsuite/gcc.target/i386/pr106994.c b/gcc/testsuite/gcc.target/i386/pr106994.c
new file mode 100644
index 00000000000..0803311dc75
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr106994.c
@@ -0,0 +1,24 @@
+/* { dg-do compile } */
+/* { dg-options "-march=skylake -Ofast" } */
+
+typedef struct {
+ float ymin, ymax;
+} rctf;
+
+rctf view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked;
+float view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
+
+void BLI_rctf_translate();
+void glLoadIdentity();
+
+void
+view2d_map_cur_using_maskUI_view2d_view_ortho() {
+ BLI_rctf_translate(&view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked);
+ view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymin =
+ __builtin_floor(view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymin) -
+ view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
+ view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymax =
+ __builtin_floor(view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymax) -
+ view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
+ glLoadIdentity();
+}
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [x86] Fix typo in floorv2sf2, should be register_operand for op1, not vector_operand.
2022-09-22 1:15 [PATCH] [x86] Fix typo in floorv2sf2, should be register_operand for op1, not vector_operand liuhongt
@ 2022-09-22 1:22 ` Hongtao Liu
2022-09-22 5:59 ` Uros Bizjak
1 sibling, 0 replies; 3+ messages in thread
From: Hongtao Liu @ 2022-09-22 1:22 UTC (permalink / raw)
To: Uros Bizjak; +Cc: gcc-patches, hjl.tools
On Thu, Sep 22, 2022 at 9:17 AM liuhongt <hongtao.liu@intel.com> wrote:
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Verify 526.blend_r can be rebuilt with the fix.
>
> Ok for trunk?
>
> gcc/ChangeLog:
>
> PR target/106994
> * config/i386/mmx.md (floorv2sf2): Fix typo, use
> register_operand instead of vector_operand for operands[1].
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/i386/pr106994.c: New test.
> ---
> gcc/config/i386/mmx.md | 2 +-
> gcc/testsuite/gcc.target/i386/pr106994.c | 24 ++++++++++++++++++++++++
> 2 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/gcc.target/i386/pr106994.c
>
> diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
> index 222a041de58..c359e2dd6de 100644
> --- a/gcc/config/i386/mmx.md
> +++ b/gcc/config/i386/mmx.md
> @@ -1676,7 +1676,7 @@ (define_expand "lceilv2sfv2si2"
> (define_expand "floorv2sf2"
> [(set (match_operand:V2SF 0 "register_operand")
> (unspec:V2SF
> - [(match_operand:V2SF 1 "vector_operand")
> + [(match_operand:V2SF 1 "register_operand")
> (match_dup 2)]
> UNSPEC_ROUND))]
> "TARGET_SSE4_1 && !flag_trapping_math
> diff --git a/gcc/testsuite/gcc.target/i386/pr106994.c b/gcc/testsuite/gcc.target/i386/pr106994.c
> new file mode 100644
> index 00000000000..0803311dc75
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr106994.c
> @@ -0,0 +1,24 @@
> +/* { dg-do compile } */
> +/* { dg-options "-march=skylake -Ofast" } */
> +
> +typedef struct {
> + float ymin, ymax;
> +} rctf;
> +
> +rctf view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked;
> +float view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
> +
> +void BLI_rctf_translate();
> +void glLoadIdentity();
> +
> +void
> +view2d_map_cur_using_maskUI_view2d_view_ortho() {
> + BLI_rctf_translate(&view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked);
> + view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymin =
> + __builtin_floor(view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymin) -
> + view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
> + view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymax =
> + __builtin_floor(view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymax) -
> + view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
> + glLoadIdentity();
> +}
> --
> 2.27.0
>
--
BR,
Hongtao
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [x86] Fix typo in floorv2sf2, should be register_operand for op1, not vector_operand.
2022-09-22 1:15 [PATCH] [x86] Fix typo in floorv2sf2, should be register_operand for op1, not vector_operand liuhongt
2022-09-22 1:22 ` Hongtao Liu
@ 2022-09-22 5:59 ` Uros Bizjak
1 sibling, 0 replies; 3+ messages in thread
From: Uros Bizjak @ 2022-09-22 5:59 UTC (permalink / raw)
To: liuhongt; +Cc: gcc-patches
On Thu, Sep 22, 2022 at 3:18 AM liuhongt via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Verify 526.blend_r can be rebuilt with the fix.
>
> Ok for trunk?
This patch is OK as obvious.
Thanks,
Uros.
> gcc/ChangeLog:
>
> PR target/106994
> * config/i386/mmx.md (floorv2sf2): Fix typo, use
> register_operand instead of vector_operand for operands[1].
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/i386/pr106994.c: New test.
> ---
> gcc/config/i386/mmx.md | 2 +-
> gcc/testsuite/gcc.target/i386/pr106994.c | 24 ++++++++++++++++++++++++
> 2 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/gcc.target/i386/pr106994.c
>
> diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
> index 222a041de58..c359e2dd6de 100644
> --- a/gcc/config/i386/mmx.md
> +++ b/gcc/config/i386/mmx.md
> @@ -1676,7 +1676,7 @@ (define_expand "lceilv2sfv2si2"
> (define_expand "floorv2sf2"
> [(set (match_operand:V2SF 0 "register_operand")
> (unspec:V2SF
> - [(match_operand:V2SF 1 "vector_operand")
> + [(match_operand:V2SF 1 "register_operand")
> (match_dup 2)]
> UNSPEC_ROUND))]
> "TARGET_SSE4_1 && !flag_trapping_math
> diff --git a/gcc/testsuite/gcc.target/i386/pr106994.c b/gcc/testsuite/gcc.target/i386/pr106994.c
> new file mode 100644
> index 00000000000..0803311dc75
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr106994.c
> @@ -0,0 +1,24 @@
> +/* { dg-do compile } */
> +/* { dg-options "-march=skylake -Ofast" } */
> +
> +typedef struct {
> + float ymin, ymax;
> +} rctf;
> +
> +rctf view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked;
> +float view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
> +
> +void BLI_rctf_translate();
> +void glLoadIdentity();
> +
> +void
> +view2d_map_cur_using_maskUI_view2d_view_ortho() {
> + BLI_rctf_translate(&view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked);
> + view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymin =
> + __builtin_floor(view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymin) -
> + view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
> + view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymax =
> + __builtin_floor(view2d_map_cur_using_maskUI_view2d_view_ortho_curmasked.ymax) -
> + view2d_map_cur_using_maskUI_view2d_view_ortho_yofs;
> + glLoadIdentity();
> +}
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-22 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 1:15 [PATCH] [x86] Fix typo in floorv2sf2, should be register_operand for op1, not vector_operand liuhongt
2022-09-22 1:22 ` Hongtao Liu
2022-09-22 5:59 ` Uros Bizjak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).