From: Uros Bizjak <ubizjak@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR target/106877: Robustify reg-stack to malformed asm.
Date: Tue, 13 Sep 2022 12:14:39 +0200 [thread overview]
Message-ID: <CAFULd4ajPAO6XnWtUDJDa1kRghg=oqH70CZxw35g94nroYHvWA@mail.gmail.com> (raw)
In-Reply-To: <020401d8c757$2af45f10$80dd1d30$@nextmovesoftware.com>
On Tue, Sep 13, 2022 at 11:57 AM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch resolves PR target/106877 an ICE-on-invalid inline-asm
> regression. An innocent upstream change means that the test case
> from PR inline-asm/84683 now hits a different assert in reg-stack.cc's
> move_for_stack_reg. Fixed by duplicating Jakub's solution to PR 84683
> https://gcc.gnu.org/pipermail/gcc-patches/2018-March/495193.html
> at this second (similar) gcc_assert.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=unix{-m32},
> with no new failures. Ok for mainline?
>
>
> 2022-09-13 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> PR target/106877
> * reg-stack.cc (move_for_stack_reg): Check for any_malformed_asm
> in gcc_assert.
>
> gcc/testsuite/ChangeLog
> PR target/106877
> * g++.dg/ext/pr106877.C: New test case.
OK.
Thanks,
Uros.
prev parent reply other threads:[~2022-09-13 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 9:56 Roger Sayle
2022-09-13 10:14 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4ajPAO6XnWtUDJDa1kRghg=oqH70CZxw35g94nroYHvWA@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).