From: Uros Bizjak <ubizjak@gmail.com>
To: Hongyu Wang <hongyu.wang@intel.com>
Cc: gcc-patches@gcc.gnu.org, hongtao.liu@intel.com
Subject: Re: [PATCH] i386: Avoid fma_chain for -march=alderlake and sapphirerapids.
Date: Wed, 7 Dec 2022 08:10:14 +0100 [thread overview]
Message-ID: <CAFULd4b-Y68-q+HC4yWRp_jMUgmjgfuJejrDE3mF6_3xB729mA@mail.gmail.com> (raw)
In-Reply-To: <20221207063644.100134-1-hongyu.wang@intel.com>
On Wed, Dec 7, 2022 at 7:36 AM Hongyu Wang <hongyu.wang@intel.com> wrote:
>
> For Alderlake there is similar issue like PR 81616, enable
> avoid_fma256_chain will also benefit on Intel latest platforms
> Alderlake and Sapphire Rapids.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu{-m32,}.
>
> Ok for master?
>
> gcc/ChangeLog:
>
> * config/i386/x86-tune.def (X86_TUNE_AVOID_256FMA_CHAINS): Add
> m_SAPPHIRERAPIDS, m_ALDERLAKE and m_CORE_ATOM.
OK.
Thanks,
Uros.
> ---
> gcc/config/i386/x86-tune.def | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/config/i386/x86-tune.def b/gcc/config/i386/x86-tune.def
> index cd66f335113..db85de20bae 100644
> --- a/gcc/config/i386/x86-tune.def
> +++ b/gcc/config/i386/x86-tune.def
> @@ -499,7 +499,8 @@ DEF_TUNE (X86_TUNE_AVOID_128FMA_CHAINS, "avoid_fma_chains", m_ZNVER)
>
> /* X86_TUNE_AVOID_256FMA_CHAINS: Avoid creating loops with tight 256bit or
> smaller FMA chain. */
> -DEF_TUNE (X86_TUNE_AVOID_256FMA_CHAINS, "avoid_fma256_chains", m_ZNVER2 | m_ZNVER3)
> +DEF_TUNE (X86_TUNE_AVOID_256FMA_CHAINS, "avoid_fma256_chains", m_ZNVER2 | m_ZNVER3
> + | m_ALDERLAKE | m_SAPPHIRERAPIDS | m_CORE_ATOM)
>
> /* X86_TUNE_V2DF_REDUCTION_PREFER_PHADDPD: Prefer haddpd
> for v2df vector reduction. */
> --
> 2.18.1
>
next prev parent reply other threads:[~2022-12-07 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 6:36 Hongyu Wang
2022-12-07 7:10 ` Uros Bizjak [this message]
2022-12-14 7:55 ` Hongyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4b-Y68-q+HC4yWRp_jMUgmjgfuJejrDE3mF6_3xB729mA@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hongyu.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).