public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* gcc.dg/weak/typeof-2: arm may use constant pool
@ 2022-03-28 23:03 Alexandre Oliva
  2022-03-29  7:12 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2022-03-28 23:03 UTC (permalink / raw)
  To: gcc-patches


Some ARM configurations, such as with -mlong-calls, load the call
target from the constant pool, breaking the expectation of the test as
on several other targets.

Tested on an affected target.  Ok to install?


for  gcc/testsuite/ChangeLog

	* gcc.dg/weak/typeof-2.c: Add arm*-*-* to targets that may
	place the call target in a constant pool.
---
 gcc/testsuite/gcc.dg/weak/typeof-2.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/testsuite/gcc.dg/weak/typeof-2.c b/gcc/testsuite/gcc.dg/weak/typeof-2.c
index afce17f53cb09..c6e45624810aa 100644
--- a/gcc/testsuite/gcc.dg/weak/typeof-2.c
+++ b/gcc/testsuite/gcc.dg/weak/typeof-2.c
@@ -40,6 +40,8 @@ int bar3 (int x)
 // { dg-final { if [string match {sh[elb1-9]*-*-*} $target_triplet ] {return} } }
 // Likewise for S/390 targets
 // { dg-final { if [string match s390*-*-* $target_triplet ] {return} } }
+// Likewise for ARM targets
+// { dg-final { if [string match arm*-*-* $target_triplet ] {return} } }
 // Likewise for CRIS targets.
 // { dg-final { if [string match cris-*-* $target_triplet ] {return} } }
 // Likewise for m68k targets.


-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: gcc.dg/weak/typeof-2: arm may use constant pool
  2022-03-28 23:03 gcc.dg/weak/typeof-2: arm may use constant pool Alexandre Oliva
@ 2022-03-29  7:12 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-03-29  7:12 UTC (permalink / raw)
  To: Alexandre Oliva; +Cc: GCC Patches

On Tue, Mar 29, 2022 at 1:04 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> Some ARM configurations, such as with -mlong-calls, load the call
> target from the constant pool, breaking the expectation of the test as
> on several other targets.
>
> Tested on an affected target.  Ok to install?

OK

>
> for  gcc/testsuite/ChangeLog
>
>         * gcc.dg/weak/typeof-2.c: Add arm*-*-* to targets that may
>         place the call target in a constant pool.
> ---
>  gcc/testsuite/gcc.dg/weak/typeof-2.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.dg/weak/typeof-2.c b/gcc/testsuite/gcc.dg/weak/typeof-2.c
> index afce17f53cb09..c6e45624810aa 100644
> --- a/gcc/testsuite/gcc.dg/weak/typeof-2.c
> +++ b/gcc/testsuite/gcc.dg/weak/typeof-2.c
> @@ -40,6 +40,8 @@ int bar3 (int x)
>  // { dg-final { if [string match {sh[elb1-9]*-*-*} $target_triplet ] {return} } }
>  // Likewise for S/390 targets
>  // { dg-final { if [string match s390*-*-* $target_triplet ] {return} } }
> +// Likewise for ARM targets
> +// { dg-final { if [string match arm*-*-* $target_triplet ] {return} } }
>  // Likewise for CRIS targets.
>  // { dg-final { if [string match cris-*-* $target_triplet ] {return} } }
>  // Likewise for m68k targets.
>
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-29  7:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 23:03 gcc.dg/weak/typeof-2: arm may use constant pool Alexandre Oliva
2022-03-29  7:12 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).