* [PATCH] [testsuite] [analyzer] include sys/select.h if available
@ 2024-04-16 3:28 Alexandre Oliva
2024-04-16 7:12 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2024-04-16 3:28 UTC (permalink / raw)
To: gcc-patches; +Cc: Rainer Orth, Mike Stump, David Malcolm
Test that calls select fails on vxworks because select is only
declared in sys/select.h. Include that header if it's present.
Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-,
aarch64-, x86- and x86_64-vxworks7r2. Ok to install?
for gcc/testsuite/ChangeLog
* gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:
Include sys/select.h if present.
---
.../fd-glibc-byte-stream-connection-server.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c
index fcbcc740170e6..f922a52238f90 100644
--- a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c
+++ b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c
@@ -8,6 +8,9 @@
#include <stdlib.h>
#include <unistd.h>
#include <sys/types.h>
+#if __has_include(<sys/select.h>)
+#include <sys/select.h>
+#endif
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [testsuite] [analyzer] include sys/select.h if available
2024-04-16 3:28 [PATCH] [testsuite] [analyzer] include sys/select.h if available Alexandre Oliva
@ 2024-04-16 7:12 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2024-04-16 7:12 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: gcc-patches, Rainer Orth, Mike Stump, David Malcolm
On Tue, Apr 16, 2024 at 5:29 AM Alexandre Oliva <oliva@adacore.com> wrote:
>
>
> Test that calls select fails on vxworks because select is only
> declared in sys/select.h. Include that header if it's present.
>
> Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-,
> aarch64-, x86- and x86_64-vxworks7r2. Ok to install?
OK
>
> for gcc/testsuite/ChangeLog
>
> * gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:
> Include sys/select.h if present.
> ---
> .../fd-glibc-byte-stream-connection-server.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c
> index fcbcc740170e6..f922a52238f90 100644
> --- a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c
> +++ b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c
> @@ -8,6 +8,9 @@
> #include <stdlib.h>
> #include <unistd.h>
> #include <sys/types.h>
> +#if __has_include(<sys/select.h>)
> +#include <sys/select.h>
> +#endif
> #include <sys/socket.h>
> #include <netinet/in.h>
> #include <arpa/inet.h>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> More tolerance and less prejudice are key for inclusion and diversity
> Excluding neuro-others for not behaving ""normal"" is *not* inclusive
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-16 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-16 3:28 [PATCH] [testsuite] [analyzer] include sys/select.h if available Alexandre Oliva
2024-04-16 7:12 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).