From: Richard Biener <richard.guenther@gmail.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [COMMITTED] Allow ranger queries on exit block.
Date: Wed, 2 Nov 2022 09:18:16 +0100 [thread overview]
Message-ID: <CAFiYyc0KPF01iVKM1J2=+ZGb0s0H+HvveH4yRNv-L+TRcqS7tw@mail.gmail.com> (raw)
In-Reply-To: <052c0ba5-79fc-ad55-bfa9-38b5b3394e11@redhat.com>
On Tue, Nov 1, 2022 at 2:20 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Ranger was not allowing the exit block to be queried for range_on_entry
> or exit, for no good reason. This removes that restriction.
>
> Interestingly, it seems that when we calculate dominance info, GCC does
> not set the dominators for the EXIT_BLOCK? I worked around it by
> starting with a single pred of the exit block for my queries, but as a
> result it doesn't support multiple exit blocks.
>
> For the record:
>
> get_immediate_dominator (CDI_DOMINATORS, EXIT_BLOCK_PTR_FOR_FN (cfun))
>
> returns NULL. Is this actually working as intended? It was unexpected
> on my part.
Yes, working as "intended". EXIT and ENTRY
basic-blocks are artificial so having dominance info for them would be
somewhat odd.
Richard.
>
> Bootstrapped on x86_64-pc-linux-gnu with no regressions. Pushed.
>
> Andrew
prev parent reply other threads:[~2022-11-02 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 13:19 Andrew MacLeod
2022-11-02 8:18 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0KPF01iVKM1J2=+ZGb0s0H+HvveH4yRNv-L+TRcqS7tw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).