From: Richard Biener <richard.guenther@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>,
Peter Bergner <bergner@linux.ibm.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] testsuite: Fix gen-vect-34.c with vect_masked_load [PR106806]
Date: Wed, 2 Nov 2022 09:29:09 +0100 [thread overview]
Message-ID: <CAFiYyc0WvQD_uEpHGY3pMiW2miLv-CXTCafo2H+LMTDY4-CpaQ@mail.gmail.com> (raw)
In-Reply-To: <3fac9b35-b170-1af7-f4d2-796f9be816bf@linux.ibm.com>
On Wed, Nov 2, 2022 at 9:03 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> This is to fix the failure on powerpc as reported in PR106806,
> the test case requires tree ifcvt pass to perform on that loop,
> and it relies on masked_load support. The fix is to guard the
> expected scan with vect_masked_load effective target.
>
> As tested on powerpc64{,le}-linux-gnu and aarch64-linux-gnu
> (cfarm machine), the failures were gone. But on
> x86_64-redhat-linux (cfarm machine) the result becomes from
> PASS to N/A. I think it's expected since that machine doesn't
> support AVX by default so both check_avx_available and
> vect_masked_load fail, it should work fine on machines with
> default AVX support, or if we adjust the current
> check_avx_available with current_compiler_flags.
>
> Is it ok for trunk?
OK
> BR,
> Kewen
> -----
> PR testsuite/106806
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/tree-ssa/gen-vect-34.c: Adjust with vect_masked_load
> effective target.
> ---
> gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c
> index 41877e05efd..c2e5dfea35f 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c
> @@ -13,4 +13,4 @@ float summul(int n, float *arg1, float *arg2)
> return res1;
> }
>
> -/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target { ! { avr-*-* pru-*-* riscv*-*-* } } } } } */
> +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target vect_masked_load } } } */
> --
> 2.27.0
prev parent reply other threads:[~2022-11-02 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 8:01 Kewen.Lin
2022-11-02 8:29 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc0WvQD_uEpHGY3pMiW2miLv-CXTCafo2H+LMTDY4-CpaQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).