From: Richard Biener <richard.guenther@gmail.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Improve sorry message for -fzero-call-used-regs
Date: Mon, 19 Sep 2022 09:44:06 +0200 [thread overview]
Message-ID: <CAFiYyc14AuizoS1i8tbXmN3Woqb_9uFqV4UmK=Om82t1ao8c2g@mail.gmail.com> (raw)
In-Reply-To: <20220918090708.4014343-1-torbjorn.svensson@foss.st.com>
On Sun, Sep 18, 2022 at 11:09 AM Torbjörn SVENSSON via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> When the -fzero-call-used-regs command line option is used with an
> unsupported value, indicate that it's a value problem instead of an
> option problem.
>
> Without the patch, the error is:
> In file included from gcc/testsuite/c-c++-common/zero-scratch-regs-8.c:5:
> gcc/testsuite/c-c++-common/zero-scratch-regs-1.c: In function 'foo':
> gcc/testsuite/c-c++-common/zero-scratch-regs-1.c:10:1: sorry, unimplemented: '-fzero-call-used-regs' not supported on this target
> 10 | }
> | ^
>
> With the patch, the error would be like this:
> In file included from gcc/testsuite/c-c++-common/zero-scratch-regs-8.c:5:
> gcc/testsuite/c-c++-common/zero-scratch-regs-1.c: In function 'foo':
> gcc/testsuite/c-c++-common/zero-scratch-regs-1.c:10:1: sorry, unimplemented: Argument 'all-arg' is not supported for '-fzero-call-used-regs' on this target
the 'A' in 'Argument' should be lower case.
Otherwise LGTM.
Richard.
> 10 | }
> | ^
>
> 2022-09-18 Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
>
> gcc/ChangeLog:
>
> * targhooks.cc (default_zero_call_used_regs): Improve sorry
> message.
>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/targhooks.cc | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/targhooks.cc b/gcc/targhooks.cc
> index b15ae19bcb6..8bfbc1d18f6 100644
> --- a/gcc/targhooks.cc
> +++ b/gcc/targhooks.cc
> @@ -93,6 +93,7 @@ along with GCC; see the file COPYING3. If not see
> #include "gimple.h"
> #include "cfgloop.h"
> #include "tree-vectorizer.h"
> +#include "options.h"
>
> bool
> default_legitimate_address_p (machine_mode mode ATTRIBUTE_UNUSED,
> @@ -1181,9 +1182,21 @@ default_zero_call_used_regs (HARD_REG_SET need_zeroed_hardregs)
> static bool issued_error;
> if (!issued_error)
> {
> + const char *name = NULL;
> + for (unsigned int i = 0; zero_call_used_regs_opts[i].name != NULL;
> + ++i)
> + if (flag_zero_call_used_regs == zero_call_used_regs_opts[i].flag)
> + {
> + name = zero_call_used_regs_opts[i].name;
> + break;
> + }
> +
> + if (!name)
> + name = "";
> +
> issued_error = true;
> - sorry ("%qs not supported on this target",
> - "-fzero-call-used-regs");
> + sorry ("Argument %qs is not supported for %qs on this target",
> + name, "-fzero-call-used-regs");
> }
> }
>
> --
> 2.25.1
>
prev parent reply other threads:[~2022-09-19 7:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 9:07 Torbjörn SVENSSON
2022-09-19 7:44 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc14AuizoS1i8tbXmN3Woqb_9uFqV4UmK=Om82t1ao8c2g@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).