From: Richard Biener <richard.guenther@gmail.com>
To: Alexander Monakov <amonakov@ispras.ru>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [committed] tree-ssa-math-opts: correct -ffp-contract= check
Date: Thu, 18 May 2023 08:15:56 +0200 [thread overview]
Message-ID: <CAFiYyc1i1dYYFvkr2aJVXCRGk6TLO9BHZmTGHcOhZoyVmgbJ8g@mail.gmail.com> (raw)
In-Reply-To: <20230517184352.32144-1-amonakov@ispras.ru>
On Wed, May 17, 2023 at 8:44 PM Alexander Monakov via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Since tree-ssa-math-opts may freely contract across statement boundaries
> we should enable it only for -ffp-contract=fast instead of disabling it
> for -ffp-contract=off.
>
> No functional change, since -ffp-contract=on is not exposed yet.
OK.
> gcc/ChangeLog:
>
> * tree-ssa-math-opts.cc (convert_mult_to_fma): Enable only for
> FP_CONTRACT_FAST (no functional change).
> ---
>
> Preapproved in PR 106092, pushed to trunk.
>
> gcc/tree-ssa-math-opts.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/tree-ssa-math-opts.cc b/gcc/tree-ssa-math-opts.cc
> index b58a2ac9e6..d71c51dc0e 100644
> --- a/gcc/tree-ssa-math-opts.cc
> +++ b/gcc/tree-ssa-math-opts.cc
> @@ -3320,7 +3320,7 @@ convert_mult_to_fma (gimple *mul_stmt, tree op1, tree op2,
> imm_use_iterator imm_iter;
>
> if (FLOAT_TYPE_P (type)
> - && flag_fp_contract_mode == FP_CONTRACT_OFF)
> + && flag_fp_contract_mode != FP_CONTRACT_FAST)
> return false;
>
> /* We don't want to do bitfield reduction ops. */
> --
> 2.39.2
>
prev parent reply other threads:[~2023-05-18 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 18:43 Alexander Monakov
2023-05-18 6:15 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1i1dYYFvkr2aJVXCRGk6TLO9BHZmTGHcOhZoyVmgbJ8g@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).