public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Makefile.in: Make recog.h depend on $(TREE_H)
@ 2023-08-15  3:13 Kewen.Lin
  2023-08-15  7:53 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Kewen.Lin @ 2023-08-15  3:13 UTC (permalink / raw)
  To: GCC Patches; +Cc: Richard Biener, Richard Sandiford, Jan-Benedict Glaw

Hi,

Commit r14-3093 introduced a random build failure on
build/gencondmd.cc building.  Since r14-3093 makes recog.h
include tree.h, which further includes (depends on) some
files that are generated during the building, such as:
all-tree.def, tree-check.h etc, when building file
build/gencondmd.cc, the build can fail if these dependencies
are not ready.  So this patch is to teach this dependence.

Thank Jan-Benedict Glaw for testing this!

gcc/ChangeLog:

        * Makefile.in (RECOG_H): Add $(TREE_H) as dependence.
---
 gcc/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 2429128cbf2..9dddb65b45d 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -991,7 +991,7 @@ GIMPLE_H = gimple.h gimple.def gsstruct.def $(VEC_H) \
        $(GGC_H) $(BASIC_BLOCK_H) $(TREE_H) tree-ssa-operands.h \
        tree-ssa-alias.h $(INTERNAL_FN_H) $(HASH_TABLE_H) is-a.h
 GCOV_IO_H = gcov-io.h version.h auto-host.h gcov-counter.def
-RECOG_H = recog.h
+RECOG_H = recog.h $(TREE_H)
 EMIT_RTL_H = emit-rtl.h
 FLAGS_H = flags.h flag-types.h $(OPTIONS_H)
 OPTIONS_H = options.h flag-types.h $(OPTIONS_H_EXTRA)
--
2.31.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Makefile.in: Make recog.h depend on $(TREE_H)
  2023-08-15  3:13 [PATCH] Makefile.in: Make recog.h depend on $(TREE_H) Kewen.Lin
@ 2023-08-15  7:53 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2023-08-15  7:53 UTC (permalink / raw)
  To: Kewen.Lin; +Cc: GCC Patches, Richard Sandiford, Jan-Benedict Glaw

On Tue, Aug 15, 2023 at 5:13 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> Commit r14-3093 introduced a random build failure on
> build/gencondmd.cc building.  Since r14-3093 makes recog.h
> include tree.h, which further includes (depends on) some
> files that are generated during the building, such as:
> all-tree.def, tree-check.h etc, when building file
> build/gencondmd.cc, the build can fail if these dependencies
> are not ready.  So this patch is to teach this dependence.
>
> Thank Jan-Benedict Glaw for testing this!

OK.

> gcc/ChangeLog:
>
>         * Makefile.in (RECOG_H): Add $(TREE_H) as dependence.
> ---
>  gcc/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 2429128cbf2..9dddb65b45d 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -991,7 +991,7 @@ GIMPLE_H = gimple.h gimple.def gsstruct.def $(VEC_H) \
>         $(GGC_H) $(BASIC_BLOCK_H) $(TREE_H) tree-ssa-operands.h \
>         tree-ssa-alias.h $(INTERNAL_FN_H) $(HASH_TABLE_H) is-a.h
>  GCOV_IO_H = gcov-io.h version.h auto-host.h gcov-counter.def
> -RECOG_H = recog.h
> +RECOG_H = recog.h $(TREE_H)
>  EMIT_RTL_H = emit-rtl.h
>  FLAGS_H = flags.h flag-types.h $(OPTIONS_H)
>  OPTIONS_H = options.h flag-types.h $(OPTIONS_H_EXTRA)
> --
> 2.31.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-15  7:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-15  3:13 [PATCH] Makefile.in: Make recog.h depend on $(TREE_H) Kewen.Lin
2023-08-15  7:53 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).