[PATCH] opts: fix --help=common with '\t' description

[PATCH] opts: fix --help=common with '\t' description

[Martin Liška]

Fixes -flto-compression option:

-  -flto-compression-level=<number>	Use z Use zlib/zstd compression level <number> for IL.
+  -flto-compression-level=<0,19> Use zlib/zstd compression level <number> for IL.

Ready for master?

Thanks,
Martin

---
 gcc/common.opt | 2 +-
 gcc/opts.cc    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index 06ef768ab78..296d6f194bf 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2106,7 +2106,7 @@ Specify the algorithm to partition symbols and vars at linktime.
 ; The initial value of -1 comes from Z_DEFAULT_COMPRESSION in zlib.h.
 flto-compression-level=
 Common Joined RejectNegative UInteger Var(flag_lto_compression_level) Init(-1) IntegerRange(0, 19)
--flto-compression-level=<number>	Use zlib/zstd compression level <number> for IL.
+Use zlib/zstd compression level <number> for IL.
 
 flto-odr-type-merging
 Common Ignore
diff --git a/gcc/opts.cc b/gcc/opts.cc
index e058aaf3697..eb5db01de17 100644
--- a/gcc/opts.cc
+++ b/gcc/opts.cc
@@ -1801,7 +1801,7 @@ print_filtered_help (unsigned int include_flags,
 	  help = new_help;
 	}
 
-      if (option->range_max != -1)
+      if (option->range_max != -1 && tab == NULL)
 	{
 	  char b[128];
 	  snprintf (b, sizeof (b), "<%d,%d>", option->range_min,
-- 
2.37.3

Re: [PATCH] opts: fix --help=common with '\t' description

[Richard Biener]

On Thu, Sep 22, 2022 at 3:59 PM Martin Liška <mliska@suse.cz> wrote:
>
> Fixes -flto-compression option:
>
> -  -flto-compression-level=<number>     Use z Use zlib/zstd compression level <number> for IL.
> +  -flto-compression-level=<0,19> Use zlib/zstd compression level <number> for IL.
>
> Ready for master?

OK

> Thanks,
> Martin
>
> ---
>  gcc/common.opt | 2 +-
>  gcc/opts.cc    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/common.opt b/gcc/common.opt
> index 06ef768ab78..296d6f194bf 100644
> --- a/gcc/common.opt
> +++ b/gcc/common.opt
> @@ -2106,7 +2106,7 @@ Specify the algorithm to partition symbols and vars at linktime.
>  ; The initial value of -1 comes from Z_DEFAULT_COMPRESSION in zlib.h.
>  flto-compression-level=
>  Common Joined RejectNegative UInteger Var(flag_lto_compression_level) Init(-1) IntegerRange(0, 19)
> --flto-compression-level=<number>       Use zlib/zstd compression level <number> for IL.
> +Use zlib/zstd compression level <number> for IL.
>
>  flto-odr-type-merging
>  Common Ignore
> diff --git a/gcc/opts.cc b/gcc/opts.cc
> index e058aaf3697..eb5db01de17 100644
> --- a/gcc/opts.cc
> +++ b/gcc/opts.cc
> @@ -1801,7 +1801,7 @@ print_filtered_help (unsigned int include_flags,
>           help = new_help;
>         }
>
> -      if (option->range_max != -1)
> +      if (option->range_max != -1 && tab == NULL)
>         {
>           char b[128];
>           snprintf (b, sizeof (b), "<%d,%d>", option->range_min,
> --
> 2.37.3
>