* [PATCH] [testsuite] [i386] require fpic for pr111497.C
@ 2024-04-16 3:42 Alexandre Oliva
2024-04-16 7:15 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2024-04-16 3:42 UTC (permalink / raw)
To: gcc-patches; +Cc: Rainer Orth, Mike Stump, Jan Hubicka, Uros Bizjak
Fix another test that uses -fPIC without requiring fpic support.
Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-,
aarch64-, x86- and x86_64-vxworks7r2. Ok to install?
PS: This is neither the first nor the last such patch. Maybe the test
harness could detect -fPIC et al in compile options and react
intelligently to them, whether by warning if dg-require-effective-target
fpic is missing, or adding it implicitly. We could have more such
smarts in the testsuite machinery. WDYT?
for gcc/testsuite/ChangeLog
* g++.target/i386/pr111497.C: Require fpic support.
---
gcc/testsuite/g++.target/i386/pr111497.C | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/g++.target/i386/pr111497.C b/gcc/testsuite/g++.target/i386/pr111497.C
index a645bb95907ee..30e2e0409ad0e 100644
--- a/gcc/testsuite/g++.target/i386/pr111497.C
+++ b/gcc/testsuite/g++.target/i386/pr111497.C
@@ -1,5 +1,6 @@
// { dg-do compile { target ia32 } }
// { dg-options "-march=i686 -mtune=generic -fPIC -O2 -g" }
+// { dg-require-effective-target fpic }
class A;
struct B { const char *b1; int b2; };
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [testsuite] [i386] require fpic for pr111497.C
2024-04-16 3:42 [PATCH] [testsuite] [i386] require fpic for pr111497.C Alexandre Oliva
@ 2024-04-16 7:15 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2024-04-16 7:15 UTC (permalink / raw)
To: Alexandre Oliva
Cc: gcc-patches, Rainer Orth, Mike Stump, Jan Hubicka, Uros Bizjak
On Tue, Apr 16, 2024 at 5:43 AM Alexandre Oliva <oliva@adacore.com> wrote:
>
>
> Fix another test that uses -fPIC without requiring fpic support.
>
> Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-,
> aarch64-, x86- and x86_64-vxworks7r2. Ok to install?
OK.
> PS: This is neither the first nor the last such patch. Maybe the test
> harness could detect -fPIC et al in compile options and react
> intelligently to them, whether by warning if dg-require-effective-target
> fpic is missing, or adding it implicitly. We could have more such
> smarts in the testsuite machinery. WDYT?
Might be a possibility I guess. There's other options like
-fprofile-* which have matching effective targets.
>
> for gcc/testsuite/ChangeLog
>
> * g++.target/i386/pr111497.C: Require fpic support.
> ---
> gcc/testsuite/g++.target/i386/pr111497.C | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/g++.target/i386/pr111497.C b/gcc/testsuite/g++.target/i386/pr111497.C
> index a645bb95907ee..30e2e0409ad0e 100644
> --- a/gcc/testsuite/g++.target/i386/pr111497.C
> +++ b/gcc/testsuite/g++.target/i386/pr111497.C
> @@ -1,5 +1,6 @@
> // { dg-do compile { target ia32 } }
> // { dg-options "-march=i686 -mtune=generic -fPIC -O2 -g" }
> +// { dg-require-effective-target fpic }
>
> class A;
> struct B { const char *b1; int b2; };
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> More tolerance and less prejudice are key for inclusion and diversity
> Excluding neuro-others for not behaving ""normal"" is *not* inclusive
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-16 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-16 3:42 [PATCH] [testsuite] [i386] require fpic for pr111497.C Alexandre Oliva
2024-04-16 7:15 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).