From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Relax assertion in profile.cc
Date: Mon, 24 Oct 2022 14:32:29 +0200 [thread overview]
Message-ID: <CAFiYyc2WydJrz_Jz_7MOs7aDciNeGcqW68Xf3AELpp00B-PDZg@mail.gmail.com> (raw)
In-Reply-To: <1910003.PYKUYFuaPT@fomalhaut>
On Mon, Oct 24, 2022 at 10:26 AM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> this assertion in branch_prob:
>
> if (bb == ENTRY_BLOCK_PTR_FOR_FN (cfun)->next_bb)
> {
> location_t loc = DECL_SOURCE_LOCATION (current_function_decl);
> gcc_checking_assert (!RESERVED_LOCATION_P (loc));
>
> had been correct until:
>
> 2021-08-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
>
> PR debug/101598
> * gcc-interface/trans.c (Subprogram_Body_to_gnu): Set the
> DECL_SOURCE_LOCATION of DECL_IGNORED_P gnu_subprog_decl to
> UNKNOWN_LOCATION.
>
> was installed.
>
> Tested on x86-64/Linux, OK for mainline and 12 branch?
OK.
>
> 2022-10-24 Eric Botcazou <ebotcazou@adacore.com>
>
> * profile.cc (branch_prob): Be prepared for ignored functions with
> DECL_SOURCE_LOCATION set to UNKNOWN_LOCATION.
>
>
> 2022-10-24 Eric Botcazou <ebotcazou@adacore.com>
>
> * gnat.dg/specs/coverage1.ads: New test.
>
> --
> Eric Botcazou
prev parent reply other threads:[~2022-10-24 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 8:25 Eric Botcazou
2022-10-24 12:32 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2WydJrz_Jz_7MOs7aDciNeGcqW68Xf3AELpp00B-PDZg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).