public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org, Tamar Christina <Tamar.Christina@arm.com>
Subject: Re: [PATCH] Fix bootstrap failure (with g++ 4.8.5) in tree-if-conv.cc.
Date: Mon, 17 Jul 2023 08:19:25 +0200	[thread overview]
Message-ID: <CAFiYyc2kgw37XXnA9GeG4A3ECCq=JOyS7SPEwAxu+vme4B3u7Q@mail.gmail.com> (raw)
In-Reply-To: <001201d9b684$e319fdd0$a94df970$@nextmovesoftware.com>

On Fri, Jul 14, 2023 at 8:56 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
>
> This patch fixes the bootstrap failure I'm seeing using gcc 4.8.5 as
>
> the host compiler.  Ok for mainline?  [I might be missing something]

OK.   Btw, while I didn't spot this during review I would appreciate
if the code could use vec.[q]sort, this should work with a lambda as
well I think.

>
>
>
>
> 2023-07-14  Roger Sayle  <roger@nextmovesoftware.com>
>
>
>
> gcc/ChangeLog
>
>         * tree-if-conv.cc (predicate_scalar_phi): Make the arguments
>
>         to the std::sort comparison lambda function const.
>
>
>
>
>
> Cheers,
>
> Roger
>
> --
>
>
>

  parent reply	other threads:[~2023-07-17  6:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 18:56 Roger Sayle
2023-07-14 19:15 ` Andrew Pinski
2023-07-17  6:19 ` Richard Biener [this message]
2023-07-17  7:19   ` Tamar Christina
2023-07-17  7:27     ` Andrew Pinski
2023-07-17  7:35       ` Tamar Christina
2023-07-17 12:00         ` Richard Biener
2023-07-17 13:48           ` Alexander Monakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc2kgw37XXnA9GeG4A3ECCq=JOyS7SPEwAxu+vme4B3u7Q@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=Tamar.Christina@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=roger@nextmovesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).