public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
	Rainer Orth <ro@cebitec.uni-bielefeld.de>,
	 Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] [testsuite] require pic for pr103074.c
Date: Wed, 24 May 2023 11:02:36 +0200	[thread overview]
Message-ID: <CAFiYyc2qXT0BEHChhqR43WOJM5H+v4K+iULK8ue+xxPM1xSFyw@mail.gmail.com> (raw)
In-Reply-To: <or4jo2qpcu.fsf@lxoliva.fsfla.org>

On Wed, May 24, 2023 at 7:19 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> Fix test that uses -fPIC without stating the requirement for PIC
> support.
>
> Bootstrapped on x86_64-linux-gnu.  Also tested on ppc- and x86-vx7r2
> with gcc-12.

OK.

> for  gcc/testsuite/ChangeLog
>
>         * gcc.target/i386/pr103074.c: Require fpic support.
> ---
>  gcc/testsuite/gcc.target/i386/pr103074.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr103074.c b/gcc/testsuite/gcc.target/i386/pr103074.c
> index 276ad82a1de1e..668d9531096dc 100644
> --- a/gcc/testsuite/gcc.target/i386/pr103074.c
> +++ b/gcc/testsuite/gcc.target/i386/pr103074.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target fpic } */
>  /* { dg-options "-march=bonnell -Os -fPIC -fschedule-insns -w" } */
>
>  void
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>

      reply	other threads:[~2023-05-24  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24  5:18 Alexandre Oliva
2023-05-24  9:02 ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc2qXT0BEHChhqR43WOJM5H+v4K+iULK8ue+xxPM1xSFyw@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=oliva@adacore.com \
    --cc=ro@cebitec.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).