public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Fix copy-headers-8.c
@ 2024-03-26  8:42 Stefan Schulze Frielinghaus
  2024-03-26  9:18 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Schulze Frielinghaus @ 2024-03-26  8:42 UTC (permalink / raw)
  To: Jan Hubicka, gcc-patches; +Cc: Stefan Schulze Frielinghaus

This fixes the test on s390x.  I'm also seeing test failures for
riscv64-suse-linux-gnu, m68k-unknown-linux-gnu, pru-unknown-elf, and
powerpc64le-unknown-linux-gnu.  However, I didn't check them so this
might or might not fix those, too.

OK for mainline?

gcc/testsuite/ChangeLog:

	* gcc.dg/tree-ssa/copy-headers-8.c: Set
	LOGICAL_OP_NON_SHORT_CIRCUIT to true.
---
 gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c b/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c
index 8b4b5e7ea81..28b4d15d87f 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c
@@ -1,5 +1,8 @@
+/* For targets where LOGICAL_OP_NON_SHORT_CIRCUIT evaluates to false, two
+   conditional jumps are emitted instead of a combined conditional which this
+   test is all about.  Thus, set it to true.  */
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ch2-details" } */
+/* { dg-options "-O2 -fdump-tree-ch2-details --param logical-op-non-short-circuit=1" } */
 
 int is_sorted(int *a, int n, int m, int k)
 {
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: Fix copy-headers-8.c
  2024-03-26  8:42 [PATCH] testsuite: Fix copy-headers-8.c Stefan Schulze Frielinghaus
@ 2024-03-26  9:18 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2024-03-26  9:18 UTC (permalink / raw)
  To: Stefan Schulze Frielinghaus; +Cc: Jan Hubicka, gcc-patches

On Tue, Mar 26, 2024 at 9:43 AM Stefan Schulze Frielinghaus
<stefansf@linux.ibm.com> wrote:
>
> This fixes the test on s390x.  I'm also seeing test failures for
> riscv64-suse-linux-gnu, m68k-unknown-linux-gnu, pru-unknown-elf, and
> powerpc64le-unknown-linux-gnu.  However, I didn't check them so this
> might or might not fix those, too.
>
> OK for mainline?

OK.

> gcc/testsuite/ChangeLog:
>
>         * gcc.dg/tree-ssa/copy-headers-8.c: Set
>         LOGICAL_OP_NON_SHORT_CIRCUIT to true.
> ---
>  gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c b/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c
> index 8b4b5e7ea81..28b4d15d87f 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/copy-headers-8.c
> @@ -1,5 +1,8 @@
> +/* For targets where LOGICAL_OP_NON_SHORT_CIRCUIT evaluates to false, two
> +   conditional jumps are emitted instead of a combined conditional which this
> +   test is all about.  Thus, set it to true.  */
>  /* { dg-do compile } */
> -/* { dg-options "-O2 -fdump-tree-ch2-details" } */
> +/* { dg-options "-O2 -fdump-tree-ch2-details --param logical-op-non-short-circuit=1" } */
>
>  int is_sorted(int *a, int n, int m, int k)
>  {
> --
> 2.43.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-26  9:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-26  8:42 [PATCH] testsuite: Fix copy-headers-8.c Stefan Schulze Frielinghaus
2024-03-26  9:18 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).