From: Richard Biener <richard.guenther@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR rtl-optimization/106421: ICE in bypass_block from non-local goto.
Date: Tue, 10 Jan 2023 11:07:54 +0100 [thread overview]
Message-ID: <CAFiYyc2xrUU3d+Px2MAYPUxbX1ExhqvCy3Hch2C7rBiw193U-A@mail.gmail.com> (raw)
In-Reply-To: <004e01d92463$7eca2700$7c5e7500$@nextmovesoftware.com>
On Mon, Jan 9, 2023 at 8:50 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch fixes PR rtl-optimization/106421, an ICE-on-valid (but
> undefined) regression. The fix, as proposed by Richard Biener, is to
> defend against BLOCK_FOR_INSN returning NULL in cprop's bypass_block.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=unix{-m32},
> with no new failures. Ok for mainline?
OK.
>
> 2023-01-09 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> PR rtl-optimization/106421
> * cprop.cc (bypass_block): Check that DEST is local to this
> function (non-NULL) before calling find_edge.
>
> gcc/testsuite/ChangeLog
> PR rtl-optimization/106421
> * gcc.dg/pr106421.c: New test case.
>
>
> Thanks in advance,
> Roger
> --
>
prev parent reply other threads:[~2023-01-10 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 19:49 Roger Sayle
2023-01-10 10:07 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2xrUU3d+Px2MAYPUxbX1ExhqvCy3Hch2C7rBiw193U-A@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).