From: Richard Biener <richard.guenther@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH RFA] driver: fix validate_switches logic
Date: Fri, 2 Dec 2022 08:50:38 +0100 [thread overview]
Message-ID: <CAFiYyc39-Nvz4TE_CZHBEgduM8_SiwUcpi4_S48j5Jxc_VaOsg@mail.gmail.com> (raw)
In-Reply-To: <orv8muz4zw.fsf@lxoliva.fsfla.org>
On Fri, Dec 2, 2022 at 7:37 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Dec 1, 2022, Jason Merrill <jason@redhat.com> wrote:
>
> > Once we see g*, starred is set. Then we see %:, and it sees that as a
> > zero-length switch, which because starred is still set, matches any and all
> > command-line options. So targets that use such a spec accept all options in
> > the driver, while ones that don't reject some, such as the recent
> > -nostdlib++.
>
> Woo, nice catch, thanks!
>
> I don't have authority to approve the patch,
> but it's ok as far as I'm concerned.
OK.
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
prev parent reply other threads:[~2022-12-02 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:50 Jason Merrill
2022-12-02 6:36 ` Alexandre Oliva
2022-12-02 7:50 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc39-Nvz4TE_CZHBEgduM8_SiwUcpi4_S48j5Jxc_VaOsg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).