From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix wrong array type conversion with different storage order
Date: Tue, 22 Nov 2022 12:22:53 +0100 [thread overview]
Message-ID: <CAFiYyc3LU=uBxnHSyG5PbLJxUHQP6mVCh4HXSSF1Wun+w_jJAw@mail.gmail.com> (raw)
In-Reply-To: <4442231.LvFx2qVVIh@fomalhaut>
On Tue, Nov 22, 2022 at 12:06 PM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> when two arrays of scalars have a different storage order in Ada, the
> front-end makes sure that the conversion is performed component-wise
> so that each component can be reversed. So it's a little bit counter
> productive that the ldist pass performs the opposite transformation
> and synthesizes a memcpy/memmove in this case.
>
> Tested on x86-64/Linux, OK for the mainline?
OK for trunk and branches.
Richard.
>
> 2022-11-22 Eric Botcazou <ebotcazou@adacore.com>
>
> * tree-loop-distribution.cc (loop_distribution::classify_builtin_ldst):
> Bail out if source and destination do not have the same storage order.
>
>
> 2022-11-22 Eric Botcazou <ebotcazou@adacore.com>
>
> * gnat.dg/sso18.adb: New test.
>
> --
> Eric Botcazou
prev parent reply other threads:[~2022-11-22 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:05 Eric Botcazou
2022-11-22 11:22 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3LU=uBxnHSyG5PbLJxUHQP6mVCh4HXSSF1Wun+w_jJAw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).