* [PATCH] Fix PR rtl-optimization/108274
@ 2023-01-13 10:49 Eric Botcazou
2023-01-13 12:55 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Eric Botcazou @ 2023-01-13 10:49 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
Hi,
unlike other IPA passes, the ICF pass can be run at -O0 and some testcases
rely on this in the testsuite. Now it effectively creates a tail call so the
DF information needs be updated in this case after epilogue creation.
Tested on x86-64/Linux, OK for mainline?
2023-01-13 Eric Botcazou <ebotcazou@adacore.com>
PR rtl-optimization/108274
* function.cc (thread_prologue_and_epilogue_insns): Also update the
DF information for calls in a few more cases.
--
Eric Botcazou
[-- Attachment #2: pr108274.diff --]
[-- Type: text/x-patch, Size: 528 bytes --]
diff --git a/gcc/function.cc b/gcc/function.cc
index d975b001ec9..95f47d287c5 100644
--- a/gcc/function.cc
+++ b/gcc/function.cc
@@ -6261,7 +6261,10 @@ thread_prologue_and_epilogue_insns (void)
/* Threading the prologue and epilogue changes the artificial refs in the
entry and exit blocks, and may invalidate DF info for tail calls. */
- if (optimize)
+ if (optimize
+ || flag_optimize_sibling_calls
+ || flag_ipa_icf_functions
+ || in_lto_p)
df_update_entry_exit_and_calls ();
else
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix PR rtl-optimization/108274
2023-01-13 10:49 [PATCH] Fix PR rtl-optimization/108274 Eric Botcazou
@ 2023-01-13 12:55 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2023-01-13 12:55 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc-patches
On Fri, Jan 13, 2023 at 11:50 AM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> unlike other IPA passes, the ICF pass can be run at -O0 and some testcases
> rely on this in the testsuite. Now it effectively creates a tail call so the
> DF information needs be updated in this case after epilogue creation.
>
> Tested on x86-64/Linux, OK for mainline?
OK.
Richard.
>
>
> 2023-01-13 Eric Botcazou <ebotcazou@adacore.com>
>
> PR rtl-optimization/108274
> * function.cc (thread_prologue_and_epilogue_insns): Also update the
> DF information for calls in a few more cases.
>
> --
> Eric Botcazou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-13 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 10:49 [PATCH] Fix PR rtl-optimization/108274 Eric Botcazou
2023-01-13 12:55 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).