From: Richard Biener <richard.guenther@gmail.com>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
David <dje.gcc@gmail.com>, "Kewen.Lin" <linkw@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH v2] Return a NULL rtx when targets don't support cbranchcc4 or predicate check fails in prepare_cmp_insn
Date: Mon, 5 Dec 2022 08:31:58 +0100 [thread overview]
Message-ID: <CAFiYyc3Xq8OF9eDZJfo85afuhN3y9xRX8-kepm07+mvHJQZS1w@mail.gmail.com> (raw)
In-Reply-To: <905c34de-6333-1021-05e6-942922918b18@linux.ibm.com>
On Mon, Dec 5, 2022 at 4:08 AM HAO CHEN GUI <guihaoc@linux.ibm.com> wrote:
>
> Hi,
> It gets an assertion failure when targers don't support cbranchcc4 or
> predicate check fails in prepare_cmp_insn. prepare_cmp_insn is a help
> function to generate compare rtx, so it should not assume that cbranchcc4
> is existing or all sub-CC modes are supported on one target. I think it
> should return the NULL rtx when cbranchcc4 is not supported or predicate check
> fails, as its callers already check if the return value is null or not for CC
> mode. This patch just does the change.
>
> Bootstrapped and tested on powerpc64-linux BE/LE and x86 with no regressions.
> Is this okay for trunk? Any recommendations? Thanks a lot.
I wonder if you have a testcase you can add showing this change is
worthwhile and
fixes a bug?
OK.
Thanks,
Richard.
>
> ChangeLog
> 2022-12-05 Haochen Gui <guihaoc@linux.ibm.com>
>
> gcc/
> * optabs.cc (prepare_cmp_insn): Return a NULL rtx other than assertion
> failure when targets don't have cbranch optab or predicate check
> fails.
>
> patch.diff
> diff --git a/gcc/optabs.cc b/gcc/optabs.cc
> index 165f8d1fa22..f6d3242479b 100644
> --- a/gcc/optabs.cc
> +++ b/gcc/optabs.cc
> @@ -4484,10 +4484,14 @@ prepare_cmp_insn (rtx x, rtx y, enum rtx_code comparison, rtx size,
> {
> enum insn_code icode = optab_handler (cbranch_optab, CCmode);
> test = gen_rtx_fmt_ee (comparison, VOIDmode, x, y);
> - gcc_assert (icode != CODE_FOR_nothing
> - && insn_operand_matches (icode, 0, test));
> - *ptest = test;
> - return;
> + if (icode != CODE_FOR_nothing
> + && insn_operand_matches (icode, 0, test))
> + {
> + *ptest = test;
> + return;
> + }
> + else
> + goto fail;
> }
>
> mclass = GET_MODE_CLASS (mode);
next prev parent reply other threads:[~2022-12-05 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 3:07 HAO CHEN GUI
2022-12-05 7:31 ` Richard Biener [this message]
2022-12-05 8:43 ` HAO CHEN GUI
2022-12-05 8:50 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3Xq8OF9eDZJfo85afuhN3y9xRX8-kepm07+mvHJQZS1w@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).