From: Richard Biener <richard.guenther@gmail.com>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
David <dje.gcc@gmail.com>, "Kewen.Lin" <linkw@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH v2] Return a NULL rtx when targets don't support cbranchcc4 or predicate check fails in prepare_cmp_insn
Date: Mon, 5 Dec 2022 09:50:05 +0100 [thread overview]
Message-ID: <CAFiYyc0yt+qU3vXkdHBT3sjnuiN0ed-HXAeTO6awOXMJMW17CQ@mail.gmail.com> (raw)
In-Reply-To: <510a5367-def4-22eb-4a47-e81d1b38f5c9@linux.ibm.com>
On Mon, Dec 5, 2022 at 9:43 AM HAO CHEN GUI <guihaoc@linux.ibm.com> wrote:
>
> Hi Richard,
>
> 在 2022/12/5 15:31, Richard Biener 写道:
> > I wonder if you have a testcase you can add showing this change is
> > worthwhile and
> > fixes a bug?
>
> I want to enable cbranchcc4 on rs6000. But not all sub CCmode is
> supported on rs6000. So the predicate check(assert) fails and it hits
> ICE. I drafted two patches. This one is for the generic code, and
> another is for rs6000. If this one is committed, cbranchcc4 can be
> enabled on rs6000. Then I can create a testcase and let the predicate
> check fail. Right now I can't write a testcase for it as it never
> reaches the failure path.
Fair enough.
> Thanks a lot
> Gui Haochen
>
prev parent reply other threads:[~2022-12-05 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 3:07 HAO CHEN GUI
2022-12-05 7:31 ` Richard Biener
2022-12-05 8:43 ` HAO CHEN GUI
2022-12-05 8:50 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc0yt+qU3vXkdHBT3sjnuiN0ed-HXAeTO6awOXMJMW17CQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).