public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Drew Ross <drross@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] match.pd: Implement missed optimization (~X | Y) ^ X -> ~(X & Y) [PR109986]
Date: Tue, 25 Jul 2023 15:42:21 -0400	[thread overview]
Message-ID: <CAGWvnym-rxQxv_KE147Nk2xvmetEx3vMfWMRDaGrf=6r4s_Qjw@mail.gmail.com> (raw)

Hi, Drew

Thanks for addressing this missed optimization.

The testcase includes an incorrect assumption: signed char, which
causes the testcase to fail on PowerPC.

Should the testcase be updated to specify signed char in the function
signatures or should -fsigned-char be added to the command line
options?

Thanks, David

             reply	other threads:[~2023-07-25 19:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 19:42 David Edelsohn [this message]
2023-07-25 19:44 ` Jakub Jelinek
2023-07-25 20:54   ` Andrew Pinski
2023-07-25 21:58     ` Andrew Pinski
2023-07-26 13:37       ` Drew Ross
  -- strict thread matches above, loose matches on Subject: below --
2023-07-05 13:41 Drew Ross
2023-07-06 13:00 ` Richard Biener
2023-07-06 19:51   ` Jakub Jelinek
2023-07-11 13:08   ` Jakub Jelinek
2023-07-11 13:58     ` Richard Biener
2023-07-19 13:17       ` Drew Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvnym-rxQxv_KE147Nk2xvmetEx3vMfWMRDaGrf=6r4s_Qjw@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=drross@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).