From: Andrew Pinski <pinskia@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: David Edelsohn <dje.gcc@gmail.com>, Drew Ross <drross@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] match.pd: Implement missed optimization (~X | Y) ^ X -> ~(X & Y) [PR109986]
Date: Tue, 25 Jul 2023 13:54:23 -0700 [thread overview]
Message-ID: <CA+=Sn1nUu+aN2Hu9uAJ3=kNnpUa4840dJ5P=yrveyC8y=i0DFg@mail.gmail.com> (raw)
In-Reply-To: <ZMAmFiicyBGX4pE6@tucnak>
On Tue, Jul 25, 2023 at 12:45 PM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Tue, Jul 25, 2023 at 03:42:21PM -0400, David Edelsohn via Gcc-patches wrote:
> > Hi, Drew
> >
> > Thanks for addressing this missed optimization.
> >
> > The testcase includes an incorrect assumption: signed char, which
> > causes the testcase to fail on PowerPC.
> >
> > Should the testcase be updated to specify signed char in the function
> > signatures or should -fsigned-char be added to the command line
> > options?
>
> I think we should use signed char instead of char in the testcase.
I also think it should be `signed char` instead as I mentioned in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110803 .
Thanks,
Andrew
>
> Jakub
>
next prev parent reply other threads:[~2023-07-25 20:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 19:42 David Edelsohn
2023-07-25 19:44 ` Jakub Jelinek
2023-07-25 20:54 ` Andrew Pinski [this message]
2023-07-25 21:58 ` Andrew Pinski
2023-07-26 13:37 ` Drew Ross
-- strict thread matches above, loose matches on Subject: below --
2023-07-05 13:41 Drew Ross
2023-07-06 13:00 ` Richard Biener
2023-07-06 19:51 ` Jakub Jelinek
2023-07-11 13:08 ` Jakub Jelinek
2023-07-11 13:58 ` Richard Biener
2023-07-19 13:17 ` Drew Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1nUu+aN2Hu9uAJ3=kNnpUa4840dJ5P=yrveyC8y=i0DFg@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=drross@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).