From: Aldy Hernandez <aldyh@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats.
Date: Wed, 9 Nov 2022 00:05:43 +0100 [thread overview]
Message-ID: <CAGm3qMVcjpndukKtavT0gM+wpZotfavTtBZhCsS=wjZJo=un4w@mail.gmail.com> (raw)
In-Reply-To: <Y2pjpHKG8Fxl7Kek@tucnak>
Sigh, one more thing.
There are further possibilities for a NAN result, even if the operands
are !NAN and the result from frange_arithmetic is free of NANs.
Adding different signed infinities.
For example, [-INF,+INF] + [-INF,+INF] has the possibility of adding
-INF and +INF, which is a NAN. Since we end up calling frange
arithmetic on the lower bounds and then on the upper bounds, we miss
this, and mistakenly think we're free of NANs.
I have a patch in testing, but FYI, in case anyone notices this before
I get around to it tomorrow.
Aldy
On Tue, Nov 8, 2022 at 3:11 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Tue, Nov 08, 2022 at 03:06:53PM +0100, Aldy Hernandez wrote:
> > +// If either operand is a NAN, set R to the combination of both NANs
> > +// signwise and return TRUE.
>
> This comment doesn't describe what it does now.
> If either operand is a NAN, set R to NAN with unspecified sign bit and return
> TRUE.
> ?
>
> Other than this LGTM.
>
> Jakub
>
next prev parent reply other threads:[~2022-11-08 23:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 12:36 Aldy Hernandez
2022-10-13 13:02 ` Toon Moene
2022-10-13 13:44 ` Aldy Hernandez
2022-10-13 13:52 ` Toon Moene
2022-10-14 8:04 ` Aldy Hernandez
2022-10-13 17:57 ` Jakub Jelinek
2022-10-17 6:21 ` Aldy Hernandez
2022-10-24 6:04 ` Aldy Hernandez
2022-10-29 4:55 ` Jeff Law
2022-10-31 8:42 ` Aldy Hernandez
2022-11-04 13:16 ` Jakub Jelinek
2022-11-04 19:14 ` Jakub Jelinek
2022-11-04 19:53 ` Jakub Jelinek
2022-11-07 12:35 ` Aldy Hernandez
2022-11-07 12:43 ` Jakub Jelinek
2022-11-07 12:48 ` Aldy Hernandez
2022-11-07 12:56 ` Jakub Jelinek
2022-11-07 15:38 ` Aldy Hernandez
2022-11-08 11:07 ` Jakub Jelinek
2022-11-08 12:47 ` Aldy Hernandez
2022-11-08 13:15 ` Jakub Jelinek
2022-11-08 14:02 ` Aldy Hernandez
2022-11-08 14:03 ` Jakub Jelinek
2022-11-07 15:41 ` Aldy Hernandez
2022-11-08 11:20 ` Jakub Jelinek
2022-11-08 13:06 ` Aldy Hernandez
2022-11-08 13:24 ` Jakub Jelinek
2022-11-08 13:47 ` Aldy Hernandez
2022-11-08 13:50 ` Jakub Jelinek
2022-11-08 14:06 ` Aldy Hernandez
2022-11-08 14:11 ` Jakub Jelinek
2022-11-08 14:14 ` Aldy Hernandez
2022-11-08 23:05 ` Aldy Hernandez [this message]
2022-11-09 6:59 ` Aldy Hernandez
2022-11-08 17:44 ` Andrew Waterman
2022-11-08 18:11 ` Jakub Jelinek
2022-11-08 18:17 ` Andrew Waterman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGm3qMVcjpndukKtavT0gM+wpZotfavTtBZhCsS=wjZJo=un4w@mail.gmail.com' \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).