Re: [PATCH] Implement known/maybe fpclassify like API for frange.

[Aldy Hernandez <aldyh@redhat.com>]

On Mon, Sep 12, 2022 at 10:48 AM Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>
> Hi Aldy!
>
> On Thu, 2022-09-08 12:56:24 +0200, Aldy Hernandez via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> > From 795baa0b044953e9f198f49e379374d633f43b47 Mon Sep 17 00:00:00 2001
> > From: Aldy Hernandez <aldyh@redhat.com>
> > Date: Thu, 8 Sep 2022 08:11:43 +0200
> > Subject: [PATCH] Implement known/maybe fpclassify like API for frange.
> >
> > gcc/ChangeLog:
> >
> >       * gimple-range-fold.cc
> >       (fold_using_range::range_of_builtin_int_call): Use fpclassify like API.
> >       * range-op-float.cc (finite_operand_p): Same.
> >       (finite_operands_p): Same.
> >       (foperator_lt::fold_range): Same.
> >       (foperator_le::fold_range): Same.
> >       (foperator_gt::fold_range): Same.
> >       (foperator_ge::fold_range): Same.
> >       (foperator_unordered::fold_range): Same.
> >       (foperator_unordered::op1_range): Same.
> >       (foperator_ordered::fold_range): Same.
> >       * value-range.cc (frange::set_nan): Same.
> >       (frange::set_signbit): Same.
> >       (frange::union_): Same.
> >       (frange::intersect): Same.
> >       (frange::operator==): Same.
> >       (frange::singleton_p): Same.
> >       (frange::verify_range): Same.
> >       (range_tests_nan): Same.
> >       (range_tests_floats): Same.
> >       * value-range.h(frange::known_finite): New.
> >       (frange::maybe_inf): New.
> >       (frange::known_inf): New.
> >       (frange::maybe_nan): New.
> >       (frange::known_nan): New.
> >       (frange::known_signbit): New.
> > ---
> >  gcc/gimple-range-fold.cc |  19 +++---
> >  gcc/range-op-float.cc    |  26 ++++----
> >  gcc/value-range.cc       | 126 +++++++++++++++++++++++----------------
> >  gcc/value-range.h        |  78 +++++++++++++++++++++++-
> >  4 files changed, 170 insertions(+), 79 deletions(-)
>
> This triggers a selftest failure for pdp11:
>
> .../gcc/configure --prefix=... --enable-werror-always --enable-languages=all --disable-gcov --disable-shared --disable-threads --target=pdp11-aout --without-headers

I have just pushed a patch to fix this.

I have also added -ffinite-math-only selftests to my list of testing
requirements for all future frange work.

Thanks for reporting this.
Aldy