public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	"MacLeod, Andrew" <amacleod@redhat.com>,
	Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader
Date: Tue, 2 Aug 2022 13:54:12 +0200	[thread overview]
Message-ID: <CAGm3qMX5_Y98V-bAeMmVKi+WsFv=bPg-T69erm27C-6qyRRo=w@mail.gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2208021141380.4208@jbgna.fhfr.qr>

On Tue, Aug 2, 2022 at 1:45 PM Richard Biener <rguenther@suse.de> wrote:
>
> On Tue, 2 Aug 2022, Aldy Hernandez wrote:
>
> > Unfortunately, this was before my time, so I don't know.
> >
> > That being said, thanks for tackling these issues that my work
> > triggered last release.  Much appreciated.
>
> Ah.  But it was your r12-324-g69e5544210e3c0 that did
>
> -  else if (n_insns > 1)
> +  else if (!m_speed_p && n_insns > 1)
>
> causing the breakage on the 12 branch.  That leads to a simpler
> fix I guess.  Will re-test and also backport to GCC 12 if successful.

Huh.  It's been a while, but that looks like a typo.  That patch was
supposed to be non-behavior changing.

Aldy


  reply	other threads:[~2022-08-02 11:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <04261.122080204410800126@us-mta-529.us.mimecast.lan>
2022-08-02 10:21 ` Aldy Hernandez
2022-08-02 11:45   ` Richard Biener
2022-08-02 11:54     ` Aldy Hernandez [this message]
2022-08-02 11:59       ` Richard Biener
2022-08-02 12:03         ` Aldy Hernandez
2022-08-02 13:29           ` Richard Biener
2022-08-02 14:25             ` Aldy Hernandez
2022-08-02 16:31         ` Jan Hubicka
2022-08-03  9:58           ` Richard Biener
     [not found] <20220802130109.AD89F385381B@sourceware.org>
2022-08-05 16:35 ` Jeff Law
2022-08-02 13:00 Richard Biener
  -- strict thread matches above, loose matches on Subject: below --
2022-08-02 13:00 Richard Biener
2022-08-02 13:00 Richard Biener
2022-08-02  8:41 Richard Biener
2022-08-02  8:41 Richard Biener
2022-08-02  8:41 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGm3qMX5_Y98V-bAeMmVKi+WsFv=bPg-T69erm27C-6qyRRo=w@mail.gmail.com' \
    --to=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).