From: Aldy Hernandez <aldyh@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Andrew MacLeod <amacleod@redhat.com>
Subject: Re: Add 'gcc.dg/tree-ssa/pr107195-3.c' [PR107195] (was: Add 'c-c++-common/torture/pr107195-1.c' [PR107195] (was: [COMMITTED] [PR107195] Set range to zero when nonzero mask is 0.))
Date: Fri, 21 Oct 2022 10:51:08 +0200 [thread overview]
Message-ID: <CAGm3qMXOSR=PaB7c6RtVxquFht_B8RDKzxzoVH6VmG-RJdxOfg@mail.gmail.com> (raw)
In-Reply-To: <875ygdefm1.fsf@dem-tschwing-1.ger.mentorg.com>
On Fri, Oct 21, 2022 at 10:38 AM Thomas Schwinge
<thomas@codesourcery.com> wrote:
>
> Hi!
>
> On 2022-10-21T00:44:30+0200, Aldy Hernandez <aldyh@redhat.com> wrote:
> > On Thu, Oct 20, 2022 at 9:22 PM Thomas Schwinge <thomas@codesourcery.com> wrote:
> >> "Add 'gcc.dg/tree-ssa/pr107195-3.c' [PR107195]" attached?
> >
> > I see 7 different tests in this patch. Did the 6 that pass, fail
> > before my patch for PR107195 and are now working? Cause unless
> > that's the case, they shouldn't be in a test named pr107195-3.c, but
> > somewhere else.
>
> That's correct; I should've mentioned that I had verified this. With the
> code changes of commit r13-3217-gc4d15dddf6b9eacb36f535807ad2ee364af46e04
> "[PR107195] Set range to zero when nonzero mask is 0" reverted, we get:
>
> PASS: gcc.dg/tree-ssa/pr107195-3.c (test for excess errors)
> FAIL: gcc.dg/tree-ssa/pr107195-3.c scan-tree-dump-times dom3 "gimple_call <foo1," 1
> FAIL: gcc.dg/tree-ssa/pr107195-3.c scan-tree-dump-times dom3 "gimple_call <foo2," 1
> FAIL: gcc.dg/tree-ssa/pr107195-3.c scan-tree-dump-times dom3 "gimple_call <foo3," 1
> FAIL: gcc.dg/tree-ssa/pr107195-3.c scan-tree-dump-times dom3 "gimple_call <foo4," 1
> FAIL: gcc.dg/tree-ssa/pr107195-3.c scan-tree-dump-times dom3 "gimple_call <foo5," 1
> FAIL: gcc.dg/tree-ssa/pr107195-3.c scan-tree-dump-times dom3 "gimple_call <foo6," 1
>
> ..., and in 'pr107195-3.c.196t.dom3' instead see two calls of each
> 'foo[...]' function.
>
> That's with this...
>
> > I see there's one XFAILed test in your patch
>
> ... XFAILed test case removed, see the attached
> "Add 'gcc.dg/tree-ssa/pr107195-3.c' [PR107195]";
> OK now to push that version?
OK, thanks.
next prev parent reply other threads:[~2022-10-21 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 8:31 [COMMITTED] [PR107195] Set range to zero when nonzero mask is 0 Aldy Hernandez
2022-10-17 7:43 ` Add 'c-c++-common/torture/pr107195-1.c' [PR107195] (was: [COMMITTED] [PR107195] Set range to zero when nonzero mask is 0.) Thomas Schwinge
2022-10-17 13:58 ` Aldy Hernandez
2022-10-17 14:46 ` Thomas Schwinge
2022-10-18 5:41 ` Aldy Hernandez
2022-10-20 11:38 ` Add 'gcc.dg/tree-ssa/pr107195-3.c' [PR107195] (was: Add 'c-c++-common/torture/pr107195-1.c' [PR107195] (was: [COMMITTED] [PR107195] Set range to zero when nonzero mask is 0.)) Thomas Schwinge
2022-10-20 12:23 ` Aldy Hernandez
2022-10-20 19:22 ` Thomas Schwinge
2022-10-20 22:44 ` Aldy Hernandez
2022-10-21 8:38 ` Thomas Schwinge
2022-10-21 8:51 ` Aldy Hernandez [this message]
2022-10-21 9:36 ` Restore 'libgomp.oacc-c-c++-common/nvptx-sese-1.c' SESE regions checking [PR107195, PR107344] (was: [COMMITTED] [PR107195] Set range to zero when nonzero mask is 0.) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGm3qMXOSR=PaB7c6RtVxquFht_B8RDKzxzoVH6VmG-RJdxOfg@mail.gmail.com' \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).