From: Aldy Hernandez <aldyh@redhat.com>
To: Martin Jambor <mjambor@suse.cz>, GCC patches <gcc-patches@gcc.gnu.org>
Cc: Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] Implement ipa_vr hashing.
Date: Mon, 26 Jun 2023 11:23:24 +0200 [thread overview]
Message-ID: <CAGm3qMXYjxCVBPRO5QzNP4MWVGzyQABh2Tiovfjh7rcxzhTHng@mail.gmail.com> (raw)
In-Reply-To: <CAGm3qMURtLdRttrTZh95pPA0U111oU-=MoX1r6mqDBNaVGnXYA@mail.gmail.com>
Errr, sorry about this ping. I was meant to re-ping my IPA patches
after 7 days, but just realized it had been only 4. My bad.
Aldy
On Mon, Jun 26, 2023 at 11:22 AM Aldy Hernandez <aldyh@redhat.com> wrote:
>
> PING*3
>
> On Thu, Jun 22, 2023 at 7:49 AM Aldy Hernandez <aldyh@redhat.com> wrote:
> >
> > Ping*2
> >
> > On Wed, Jun 14, 2023, 14:11 Aldy Hernandez <aldyh@redhat.com> wrote:
> >>
> >> PING
> >>
> >> On Sat, Jun 10, 2023 at 10:30 PM Aldy Hernandez <aldyh@redhat.com> wrote:
> >> >
> >> >
> >> >
> >> > On 5/29/23 16:51, Martin Jambor wrote:
> >> > > Hi,
> >> > >
> >> > > On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote:
> >> > >> Implement hashing for ipa_vr. When all is said and done, all these
> >> > >> patches incurr a 7.64% slowdown for ipa-cp, with is entirely covered by
> >> > >> the similar 7% increase in this area last week. So we get type agnostic
> >> > >> ranges with "infinite" range precision close to free.
> >> > >
> >> > > Do you know why/where this slow-down happens? Do we perhaps want to
> >> > > limit the "infiniteness" a little somehow?
> >> >
> >> > I addressed the slow down in another mail.
> >> >
> >> > >
> >> > > Also, jump functions live for a long time, have you looked at how memory
> >> > > hungry they become? I hope that the hashing would be good at preventing
> >> > > any issues.
> >> >
> >> > On a side-note, the caching does help. On a (mistaken) hunch, I had
> >> > played around with removing caching for everything but UNDEFINED/VARYING
> >> > and zero/nonzero to simplify things, but the cache hit ratio was still
> >> > surprisingly high (+80%). So good job there :-).
> >> >
> >> > >
> >> > > Generally, I think I OK with the patches if the impact on memory is not
> >> > > too bad, though I guess they depend on the one I looked at last week, so
> >> > > we may focus on that one first.
> >> >
> >> > I'm not sure whether this was an OK for the other patches, given you
> >> > approved the first patch, so I'll hold off until you give the go-ahead.
> >> >
> >> > Thanks.
> >> > Aldy
next prev parent reply other threads:[~2023-06-26 9:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 18:56 [PATCH] Convert ipa_jump_func to use ipa_vr instead of a value_range Aldy Hernandez
2023-05-22 18:56 ` [PATCH] Implement ipa_vr hashing Aldy Hernandez
2023-05-29 14:51 ` Martin Jambor
2023-06-07 10:01 ` Aldy Hernandez
2023-06-10 20:30 ` Aldy Hernandez
2023-06-14 12:11 ` Aldy Hernandez
2023-06-22 5:49 ` Aldy Hernandez
2023-06-26 9:22 ` Aldy Hernandez
2023-06-26 9:23 ` Aldy Hernandez [this message]
2023-06-26 16:40 ` Martin Jambor
2023-05-22 18:56 ` [PATCH] Convert remaining uses of value_range in ipa-*.cc to Value_Range Aldy Hernandez
2023-06-14 12:10 ` Aldy Hernandez
2023-06-22 5:49 ` Aldy Hernandez
2023-06-26 16:41 ` Martin Jambor
2023-06-14 12:09 ` [PATCH] Convert ipa_jump_func to use ipa_vr instead of a value_range Aldy Hernandez
2023-06-22 5:49 ` Aldy Hernandez
2023-06-26 16:40 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm3qMXYjxCVBPRO5QzNP4MWVGzyQABh2Tiovfjh7rcxzhTHng@mail.gmail.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).